Issue 5987058: code review 5987058: crypto/tls: don't always use the default private key.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5987058: code review 5987058: crypto/tls: don't always use the default private key. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by agl1

Modified:
12 years ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

crypto/tls: don't always use the default private key. When SNI based certificate selection is enabled, we previously used the default private key even if we selected a non-default certificate. Fixes issue 3367.

Patch Set 1 #

Patch Set 2 : diff -r 2376ffb966ed https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b9cbd32246e3 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b9cbd32246e3 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 5eadbc72f1d2 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+177 lines, -26 lines)			Patch
M	src/pkg/crypto/tls/cipher_suites.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/tls/handshake_server.go	View	1	2 chunks	+15 lines, -14 lines	0 comments	Download
M	src/pkg/crypto/tls/handshake_server_test.go	View	1 2	6 chunks	+154 lines, -4 lines	0 comments	Download
M	src/pkg/crypto/tls/key_agreement.go	View	1	5 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2012-04-11 18:45:56 UTC) #1

agl1

12 years ago (2012-04-12 16:35:28 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=6a2ea47583df ***

crypto/tls: don't always use the default private key.

When SNI based certificate selection is enabled, we previously used
the default private key even if we selected a non-default certificate.

Fixes issue 3367.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5987058

Expand All Messages | Collapse All Messages