code review 5970076: sql: Propagate error from subsetTypeArgs in Exec

sql: Propagate error from subsetTypeArgs in Exec

Fixes issue 3449

[mikelewis, 2012-04-03 21:43:42]

Hello golang-dev@googlegroups.com (cc: bradfitz@golang.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-04-03 22:34:03]

LGTM

On Tue, Apr 3, 2012 at 2:43 PM, <mikelikespie@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: bradfitz@golang.org),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> sql: Propagate error from subsetTypeArgs in Exec
>
> Fixes issue 3449
>
> Please review this at
http://codereview.appspot.com/**5970076/<http://codereview.appspot.com/5970076/>
>
> Affected files:
>  M src/pkg/database/sql/sql.go
>
>
> Index: src/pkg/database/sql/sql.go
> ==============================**==============================**=======
> --- a/src/pkg/database/sql/sql.go
> +++ b/src/pkg/database/sql/sql.go
> @@ -327,6 +327,9 @@
>  // Exec executes a query without returning any rows.
>  func (db *DB) Exec(query string, args ...interface{}) (Result, error) {
>        sargs, err := subsetTypeArgs(args)
> +       if err != nil {
> +               return nil, err
> +       }
>        var res Result
>        for i := 0; i < 10; i++ {
>                res, err = db.exec(query, sargs)
>
>
>

[bradfitz, 2012-04-03 22:36:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=dd8f13acda2e ***

sql: Propagate error from subsetTypeArgs in Exec

Fixes issue 3449

R=golang-dev
CC=bradfitz, golang-dev
http://codereview.appspot.com/5970076

Committer: Brad Fitzpatrick <bradfitz@golang.org>