code review 5970050: net/url: Correctly escape URL as per RFC 3986

net/url: Correctly escape URL as per RFC 3986

The shouldEscape function did not correctly escape the reserved characters listed in RFC 3986 §2.2, breaking some strict web servers.
Fixes issue 3433.

[stephane.travostino, 2012-03-30 19:52:45]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2012-04-02 16:02:53]

Please add tests for the other characters.
More changed than just '!'.

http://codereview.appspot.com/5970050/diff/3001/src/pkg/net/url/url.go
File src/pkg/net/url/url.go (right):

http://codereview.appspot.com/5970050/diff/3001/src/pkg/net/url/url.go#newcode64
src/pkg/net/url/url.go:64: // appearing in a URL string, according to RFC 2396
and RFC 3986.
s/RFC 2396 and //

RFC 2396 is dead, according to http://tools.ietf.org/html/rfc2396

[stephane.travostino, 2012-04-04 18:02:45]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[stephane.travostino, 2012-04-04 18:04:11]

On 2012/04/02 16:02:53, rsc wrote:
> Please add tests for the other characters.
> More changed than just '!'.
> 
> http://codereview.appspot.com/5970050/diff/3001/src/pkg/net/url/url.go
> File src/pkg/net/url/url.go (right):
> 
>
http://codereview.appspot.com/5970050/diff/3001/src/pkg/net/url/url.go#newcode64
> src/pkg/net/url/url.go:64: // appearing in a URL string, according to RFC 2396
> and RFC 3986.
> s/RFC 2396 and //
> 
> RFC 2396 is dead, according to http://tools.ietf.org/html/rfc2396

PTAL, I have uploaded a new patch set with the suggested changes.

[rsc, 2012-04-05 15:15:40]

LGTM

Thank you.

[rsc, 2012-04-05 15:17:16]

It looks like you have not completed a CLA,
so I can't submit this yet.

Please complete a CLA as described at
http://golang.org/doc/contribute.html#copyright

Thanks.
Russ

[stephane.travostino, 2012-04-05 16:09:11]

Done.

Thank you for accepting the patch.

On 2012/04/05 15:17:16, rsc wrote:
> It looks like you have not completed a CLA,
> so I can't submit this yet.
> 
> Please complete a CLA as described at
> http://golang.org/doc/contribute.html#copyright
> 
> Thanks.
> Russ

[rsc, 2012-04-05 17:23:12]

*** Submitted as http://code.google.com/p/go/source/detail?r=6b46fb967ca4 ***

net/url: Correctly escape URL as per RFC 3986

The shouldEscape function did not correctly escape the reserved characters
listed in RFC 3986 §2.2, breaking some strict web servers.
Fixes issue 3433.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5970050

Committer: Russ Cox <rsc@golang.org>