Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(819)

Issue 5909045: code review 5909045: doc: Change id of footer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by bsiegert
Modified:
12 years, 11 months ago
Reviewers:
CC:
golang-dev, bradfitz, rsc
Visibility:
Public.

Description

doc: Change id of footer The heading "Copyright" uses id="copyright" as the anchor name. However, there is also a <div id="copyright"> at the bottom. Using the same ID value twice in the same file is illegal (http://www.w3.org/TR/html401/struct/links.html#h-12.2.3).

Patch Set 1 #

Patch Set 2 : diff -r 044bac21548f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 044bac21548f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 044bac21548f https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 044bac21548f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M doc/style.css View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M lib/godoc/godoc.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
bsiegert
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 11 months ago (2012-03-24 11:26:00 UTC) #1
bradfitz
I'd rather change the page footer's copyright id. We've often linked to /doc/contribute.html#copyright when telling ...
12 years, 11 months ago (2012-03-24 16:30:58 UTC) #2
bsiegert
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 11 months ago (2012-03-24 20:03:30 UTC) #3
rsc
LGTM. Leaving for Brad/Robert.
12 years, 11 months ago (2012-03-26 13:15:52 UTC) #4
bradfitz
LGTM On Sat, Mar 24, 2012 at 1:03 PM, <bsiegert@gmail.com> wrote: > Hello golang-dev@googlegroups.com, bradfitz@golang.org ...
12 years, 11 months ago (2012-03-26 16:12:00 UTC) #5
bradfitz
12 years, 11 months ago (2012-03-26 16:13:45 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=556341822a38 ***

doc: Change id of footer

The heading "Copyright" uses id="copyright" as the anchor name.
However, there is also a <div id="copyright"> at the bottom.
Using the same ID value twice in the same file is illegal
(http://www.w3.org/TR/html401/struct/links.html#h-12.2.3).

R=golang-dev, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/5909045

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b