code review 5909043: syscall: support Getpid() on Windows

syscall: support Getpid() on Windows
        Fixes issue 3379.

[minux1, 2012-03-24 09:52:19]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[brainman, 2012-03-25 09:01:27]

LGTM

I think we should submit it now, because it is broken anyway. But leaving for
someone from Go team to decide.

I also think we should have replaced os.Getpid with 

func CurrentProcess() Process

in os. But, it is, probably, too late now.

Alex

http://codereview.appspot.com/5909043/diff/3007/src/pkg/syscall/syscall_windo...
File src/pkg/syscall/syscall_windows.go (right):

http://codereview.appspot.com/5909043/diff/3007/src/pkg/syscall/syscall_windo...
src/pkg/syscall/syscall_windows.go:201: //sys	GetCurrentProcessId() (pid int) =
kernel32.GetCurrentProcessId
It acturally returns DWORD, so
s/int/uint32/

[minux1, 2012-03-25 15:28:44]

PTAL.
On 2012/03/25 09:01:27, brainman wrote:
> I think we should submit it now, because it is broken anyway. But leaving for
> someone from Go team to decide.
I agree. Being able to get pid is very useful esp. in logging.
> I also think we should have replaced os.Getpid with  
> func CurrentProcess() Process
> in os. But, it is, probably, too late now.
IMO, we could just add this after Go 1, and leave Getpid() as is because
it is frequently used and warrant a shortcut.
>
http://codereview.appspot.com/5909043/diff/3007/src/pkg/syscall/syscall_windo...
> src/pkg/syscall/syscall_windows.go:201: //sys	GetCurrentProcessId() (pid int)
=
> kernel32.GetCurrentProcessId
> It acturally returns DWORD, so
> s/int/uint32/
Done.

[brainman, 2012-03-25 22:28:12]

SLGTM

But, please, wait for others.

Alex

http://codereview.appspot.com/5909043/diff/4/src/pkg/syscall/syscall_windows.go
File src/pkg/syscall/syscall_windows.go (right):

http://codereview.appspot.com/5909043/diff/4/src/pkg/syscall/syscall_windows....
src/pkg/syscall/syscall_windows.go:201: //sys	GetCurrentProcessId() (pid uint) =
kernel32.GetCurrentProcessId
s/uint/uint32/

uint could be either 32 or 64 bits, but GetCurrentProcessId returns DWORD
(http://goo.gl/JBfTY), so it is uint32 in Go.

[minux1, 2012-03-26 01:42:06]

PTAL.
On 2012/03/25 22:28:12, brainman wrote:
http://codereview.appspot.com/5909043/diff/4/src/pkg/syscall/syscall_windows....
> src/pkg/syscall/syscall_windows.go:201: //sys	GetCurrentProcessId() (pid uint)
=
> kernel32.GetCurrentProcessId
> s/uint/uint32/
Oh, sorry, I thought you were suggesting uint.

[brainman, 2012-03-26 02:18:49]

LGTM

I am stuttering :-)

Alex

[rsc, 2012-03-26 12:58:20]

Thanks, but after Go 1 please.

[minux1, 2012-04-10 07:08:19]

ping?

[bradfitz, 2012-04-10 12:26:28]

LGTM but I think this will break all.bash.

We'll need to update the policy in the cmd/api tool first, to allow API
additions now.

[minux1, 2012-04-10 13:11:02]

On 2012/04/10 12:26:28, bradfitz wrote:
> We'll need to update the policy in the cmd/api tool first, to allow API
> additions now.
How about http://codereview.appspot.com/5991081/ ?

[minux1, 2012-04-10 14:34:45]

*** Submitted as http://code.google.com/p/go/source/detail?r=6436d0889d29 ***

syscall: support Getpid() on Windows
        Fixes issue 3379.

R=golang-dev, alex.brainman, rsc, bradfitz
CC=golang-dev
http://codereview.appspot.com/5909043