Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(101)

Issue 5907047: code review 5907047: effective_go: cleanups and fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by r
Modified:
12 years, 11 months ago
Reviewers:
CC:
golang-dev, minux1, bradfitz
Visibility:
Public.

Description

effective_go: cleanups and fixes Also explain the situation with recursive String methods more accurately, and clean up the code now that the fmt package is more careful.

Patch Set 1 #

Total comments: 3

Patch Set 2 : diff -r baeb068aac25 https://code.google.com/p/go/ #

Patch Set 3 : diff -r baeb068aac25 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -22 lines) Patch
M doc/effective_go.html View 1 9 chunks +39 lines, -13 lines 0 comments Download
M doc/progs/eff_bytesize.go View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years, 11 months ago (2012-03-24 13:26:17 UTC) #1
minux1
two tiny points. http://codereview.appspot.com/5907047/diff/1/doc/effective_go.html File doc/effective_go.html (right): http://codereview.appspot.com/5907047/diff/1/doc/effective_go.html#newcode731 doc/effective_go.html:731: // Compare returns an integer comparing ...
12 years, 11 months ago (2012-03-24 16:25:51 UTC) #2
bradfitz
LGTM http://codereview.appspot.com/5907047/diff/1/doc/effective_go.html File doc/effective_go.html (right): http://codereview.appspot.com/5907047/diff/1/doc/effective_go.html#newcode638 doc/effective_go.html:638: if m[key].expired() { Using m[key] instead of v ...
12 years, 11 months ago (2012-03-24 16:28:33 UTC) #3
r
Hello golang-dev@googlegroups.com, minux.ma@gmail.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 11 months ago (2012-03-24 21:21:26 UTC) #4
bradfitz
LGTM On Sat, Mar 24, 2012 at 2:21 PM, <r@golang.org> wrote: > Hello golang-dev@googlegroups.com, minux.ma@gmail.com, ...
12 years, 11 months ago (2012-03-24 23:26:25 UTC) #5
r
12 years, 11 months ago (2012-03-25 00:35:03 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=efe15ae0f630 ***

effective_go: cleanups and fixes
Also explain the situation with recursive String methods more accurately,
and clean up the code now that the fmt package is more careful.

R=golang-dev, minux.ma, bradfitz
CC=golang-dev
http://codereview.appspot.com/5907047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b