code review 5907047: effective_go: cleanups and fixes

effective_go: cleanups and fixes
Also explain the situation with recursive String methods more accurately,
and clean up the code now that the fmt package is more careful.

[r, 2012-03-24 13:26:17]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[minux1, 2012-03-24 16:25:51]

two tiny points.

http://codereview.appspot.com/5907047/diff/1/doc/effective_go.html
File doc/effective_go.html (right):

http://codereview.appspot.com/5907047/diff/1/doc/effective_go.html#newcode731
doc/effective_go.html:731: // Compare returns an integer comparing the two byte
arrays.
why period here? I think the sentence is not ended here.

http://codereview.appspot.com/5907047/diff/1/doc/effective_go.html#newcode2549
doc/effective_go.html:2549: separate pieces that can execute independently, it
can be parallelized, with a channel to signal
consider add a line break after "parallelized," ?

[bradfitz, 2012-03-24 16:28:33]

LGTM

http://codereview.appspot.com/5907047/diff/1/doc/effective_go.html
File doc/effective_go.html (right):

http://codereview.appspot.com/5907047/diff/1/doc/effective_go.html#newcode638
doc/effective_go.html:638: if m[key].expired() {
Using m[key] instead of v from range is a bad example. Maybe just:

if expired(key) {
   delete(m, key)
}

[r, 2012-03-24 21:21:26]

Hello golang-dev@googlegroups.com, minux.ma@gmail.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-03-24 23:26:25]

LGTM

On Sat, Mar 24, 2012 at 2:21 PM, <r@golang.org> wrote:

> Hello golang-dev@googlegroups.com, minux.ma@gmail.com,
> bradfitz@golang.org (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**5907047/<http://codereview.appspot.com/5907047/>
>

[r, 2012-03-25 00:35:03]

*** Submitted as http://code.google.com/p/go/source/detail?r=efe15ae0f630 ***

effective_go: cleanups and fixes
Also explain the situation with recursive String methods more accurately,
and clean up the code now that the fmt package is more careful.

R=golang-dev, minux.ma, bradfitz
CC=golang-dev
http://codereview.appspot.com/5907047