Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(668)

Issue 5905062: code review 5905062: run.bash: set -e in new codewalk block (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by r
Modified:
12 years, 11 months ago
Reviewers:
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

run.bash: set -e in new codewalk block Otherwise we won't fail if something goes wrong. This shell programming stuff is tricky.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/run.bash View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years, 11 months ago (2012-03-26 06:01:39 UTC) #1
dsymonds
LGTM
12 years, 11 months ago (2012-03-26 06:02:15 UTC) #2
dsymonds
12 years, 11 months ago (2012-03-26 06:03:10 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=f4d10ecbb7e7 ***

run.bash: set -e in new codewalk block
Otherwise we won't fail if something goes wrong.
This shell programming stuff is tricky.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5905062

Committer: David Symonds <dsymonds@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b