code review 5901064: net/http: reuse http proxy connections for different ht...

net/http: reuse http proxy connections for different http requests

Comment on cache keys above connectMethod says "http to proxy, http
anywhere after that", however in reality target address was always
included, which prevented http requests to different target
addresses to reuse the same http proxy connection.

[snaury, 2012-03-26 21:48:44]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r2, 2012-03-26 21:57:34]

This can wait until after Go 1.

-rob

[rsc, 2012-03-26 21:58:28]

Thanks but we're close to Go 1, and it's too late for changes like this.
After Go 1 is out, please remind us about this CL.

[snaury, 2012-03-26 22:00:07]

On 2012/03/26 21:58:28, rsc wrote:
> Thanks but we're close to Go 1, and it's too late for changes like this.
> After Go 1 is out, please remind us about this CL.

Ok, no problem. :)

[snaury, 2012-05-17 21:24:06]

On 2012/03/26 22:00:07, snaury wrote:
> On 2012/03/26 21:58:28, rsc wrote:
> > Thanks but we're close to Go 1, and it's too late for changes like this.
> > After Go 1 is out, please remind us about this CL.

Hi, I'm kindly reminding you of this patch. My patch still seems to apply to go
tip, and tests seem to pass. Is this fix desired?

Are there any problems I need to resolve?

One problem might be the connection in the cache expiring (proxy server
disconnects us) by the time we try to reuse it, so making a request will fail on
the first write. Should we make another connection and retry in that case?

[bradfitz, 2012-05-28 17:45:49]

LGTM

Thanks for finding this.

[bradfitz, 2012-05-28 17:46:57]

*** Submitted as http://code.google.com/p/go/source/detail?r=d0bc02d414c7 ***

net/http: reuse http proxy connections for different http requests

Comment on cache keys above connectMethod says "http to proxy, http
anywhere after that", however in reality target address was always
included, which prevented http requests to different target
addresses to reuse the same http proxy connection.

R=golang-dev, r, rsc, bradfitz
CC=golang-dev
http://codereview.appspot.com/5901064

Committer: Brad Fitzpatrick <bradfitz@golang.org>

[snaury, 2012-07-02 18:59:11]

*** Abandoned ***