Issue 5901051: code review 5901051: go/build: cgoEnabled is not known to cmd/dist anymore

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5901051: code review 5901051: go/build: cgoEnabled is not known to cmd/dist anymore (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by minux1

Modified:
12 years, 11 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

go/build: cgoEnabled is not known to cmd/dist anymore

Patch Set 1 #

Patch Set 2 : diff -r ee5c7588cb7f https://code.google.com/p/go/ #

Patch Set 3 : diff -r f707188b1ec3 https://code.google.com/p/go/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/pkg/go/build/build.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 11 months ago (2012-03-25 18:02:35 UTC) #1

bradfitz

LGTM On Sun, Mar 25, 2012 at 11:02 AM, <minux.ma@gmail.com> wrote: > Reviewers: golang-dev_googlegroups.com, > ...

12 years, 11 months ago (2012-03-25 21:11:36 UTC) #2

minux1

12 years, 11 months ago (2012-03-26 02:00:23 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e03e5e19e681 ***

go/build: cgoEnabled is not known to cmd/dist anymore

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5901051

Expand All Messages | Collapse All Messages