|
|
Created:
12 years, 11 months ago by Joe Poirier Modified:
12 years, 8 months ago Reviewers:
CC:
golang-dev, bradfitz, aram Visibility:
Public. |
Descriptionwindows: install fixes
* set default installation drive to C:\
* remove Win64 component property
Patch Set 1 #Patch Set 2 : diff -r baeb068aac25 https://go.googlecode.com/hg/ #Patch Set 3 : diff -r baeb068aac25 https://go.googlecode.com/hg/ #
Total comments: 2
Patch Set 4 : diff -r baeb068aac25 https://go.googlecode.com/hg/ #MessagesTotal messages: 13
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
Sign in to reply to this message.
LGTM What's the result of not setting the default to C:\ ? What else would it default to or do? On Sat, Mar 24, 2012 at 3:23 PM, <jdpoirier@gmail.com> wrote: > Reviewers: golang-dev_googlegroups.com, > > Message: > Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), > > I'd like you to review this change to > https://go.googlecode.com/hg/ > > > Description: > windows: install fixes > > * set default installation drive to C:\ > * remove Win64 component property > > Please review this at http://codereview.appspot.com/**5901044/<http://codereview.appspot.com/5901044/> > > Affected files: > M misc/dist/windows/installer.**wxs > > > Index: misc/dist/windows/installer.**wxs > ==============================**==============================**======= > --- a/misc/dist/windows/installer.**wxs > +++ b/misc/dist/windows/installer.**wxs > @@ -51,6 +51,7 @@ > <Media Id='1' Cabinet="go.cab" EmbedCab="yes" CompressionLevel="high" /> > <Condition Message="Windows 2000 or greater required."> VersionNT >= > 500</Condition> > <MajorUpgrade AllowDowngrades="yes" /> > +<SetDirectory Id="INSTALLDIRROOT" Value="C:\"/> > > <CustomAction > Id="**SetApplicationRootDirectory" > @@ -72,7 +73,7 @@ > > <!-- Programs Menu Shortcuts --> > <DirectoryRef Id="GoProgramShortcutsDir"> > - <Component Id="Component_**GoProgramShortCuts" > Guid="{f5fbfb5e-6c5c-423b-**9298-21b0e3c98f4b}" > Win64="$(var.IsX64Target)"> > + <Component Id="Component_**GoProgramShortCuts" > Guid="{f5fbfb5e-6c5c-423b-**9298-21b0e3c98f4b}"> > <Shortcut > Id="**GoDocServerStartMenuShortcut" > Name="GoDocServer" > @@ -102,7 +103,7 @@ > > <!-- Registry & Environment Settings --> > <DirectoryRef Id="GoEnvironmentEntries"> > - <Component Id="Component_GoEnvironment" Guid="{3ec7a4d5-eb08-4de7-**9312-2df392c45993}" > Win64="$(var.IsX64Target)"> > + <Component Id="Component_GoEnvironment" Guid="{3ec7a4d5-eb08-4de7-** > 9312-2df392c45993}"> > <RegistryKey > Root="HKCU" > Key="Software\**GoProgrammingLanguage" > > >
Sign in to reply to this message.
http://codereview.appspot.com/5901044/diff/4001/misc/dist/windows/installer.wxs File misc/dist/windows/installer.wxs (right): http://codereview.appspot.com/5901044/diff/4001/misc/dist/windows/installer.w... misc/dist/windows/installer.wxs:54: <SetDirectory Id="INSTALLDIRROOT" Value="C:\"/> Should use %SystemDrive%, it can be different from C:\ and C:\ might not exist.
Sign in to reply to this message.
On 2012/03/24 23:25:10, bradfitz wrote: > LGTM > > What's the result of not setting the default to C:\ ? What else would it > default to or do? It's not always the system drive, and I'm not sure how it decides.
Sign in to reply to this message.
http://codereview.appspot.com/5901044/diff/4001/misc/dist/windows/installer.wxs File misc/dist/windows/installer.wxs (right): http://codereview.appspot.com/5901044/diff/4001/misc/dist/windows/installer.w... misc/dist/windows/installer.wxs:54: <SetDirectory Id="INSTALLDIRROOT" Value="C:\"/> On 2012/03/24 23:32:06, aram wrote: > Should use %SystemDrive%, it can be different from C:\ and C:\ might not exist. Good catch! Done
Sign in to reply to this message.
If someone could build and test the windows-amd64 version it would be much appreciated. -joe
Sign in to reply to this message.
Sorry, I assumed you'd already tested this when I LGTM'd. On Sat, Mar 24, 2012 at 5:56 PM, <jdpoirier@gmail.com> wrote: > If someone could build and test the windows-amd64 version it would be > much appreciated. > -joe > > http://codereview.appspot.com/**5901044/<http://codereview.appspot.com/5901044/> >
Sign in to reply to this message.
On Sat, Mar 24, 2012 at 7:59 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > Sorry, I assumed you'd already tested this when I LGTM'd. Sorry, I'm not setup for the amd64 builds. BTW, what's the setup you're using to make the amd64 releases? -joe
Sign in to reply to this message.
On Sat, Mar 24, 2012 at 6:58 PM, Joseph Poirier <jdpoirier@gmail.com> wrote: > On Sat, Mar 24, 2012 at 7:59 PM, Brad Fitzpatrick <bradfitz@golang.org> > wrote: > > Sorry, I assumed you'd already tested this when I LGTM'd. > > Sorry, I'm not setup for the amd64 builds. BTW, what's the setup > you're using to make the amd64 releases? A 64-bit Windows VM on Rackspace. (We use Amazon for 32-bit, and Rackspace for 64-bit, because previously Amazon didn't have cheap 64-bit instances available, but they do in the past ~month...) It's Windows 2003 Datacenter Edition, IIRC, whatever that means.
Sign in to reply to this message.
On Sat, Mar 24, 2012 at 9:07 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > > > On Sat, Mar 24, 2012 at 6:58 PM, Joseph Poirier <jdpoirier@gmail.com> wrote: >> >> On Sat, Mar 24, 2012 at 7:59 PM, Brad Fitzpatrick <bradfitz@golang.org> >> wrote: >> > Sorry, I assumed you'd already tested this when I LGTM'd. >> >> Sorry, I'm not setup for the amd64 builds. BTW, what's the setup >> you're using to make the amd64 releases? > > > A 64-bit Windows VM on Rackspace. (We use Amazon for 32-bit, and Rackspace > for 64-bit, because previously Amazon didn't have cheap 64-bit instances > available, but they do in the past ~month...) > > It's Windows 2003 Datacenter Edition, IIRC, whatever that means. > What MinGW/GCC are you using? I'm running a 64-bit Windows 7 with a standard MinGW/GCC setup and I get errors when I try and build a windows-amd64 release.
Sign in to reply to this message.
On Sat, Mar 24, 2012 at 10:04 PM, Joseph Poirier <jdpoirier@gmail.com> wrote: > On Sat, Mar 24, 2012 at 9:07 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > > What MinGW/GCC are you using? > > I'm running a 64-bit Windows 7 with a standard MinGW/GCC setup and I > get errors when I try and build a windows-amd64 release. I downloaded the MinGW64 that (I think) Alex put together. I was able to build the installer and everything seems to be working. I did get some missing file errors during the file harvest stage of the msi builder - do you see these erros? Post installation of the tools using the msi installer, the files that were listed as missing during the installer build aren't actually missing!? I'm making modifications to installer.wxs locally then cloning tip and setting verbose mode: > bindist -repo="C:\Go" -tag=tip -upload=false -v=true windows-amd64
Sign in to reply to this message.
LGTM Tested on windows-amd64.
Sign in to reply to this message.
*** Submitted as http://code.google.com/p/go/source/detail?r=c5a91a745639 *** windows: install fixes * set default installation drive to C:\ * remove Win64 component property R=golang-dev, bradfitz, aram CC=golang-dev http://codereview.appspot.com/5901044 Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.
|