Issue 5900065: code review 5900065: text/template: pipelined arg was not typechecked

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5900065: code review 5900065: text/template: pipelined arg was not typechecked (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by r

Modified:
12 years ago

Reviewers:

CC:
golang-dev, dsymonds, rsc

Visibility:
Public.

Description

text/template: pipelined arg was not typechecked Without this fix, an erroneous template causes a panic; should be caught safely. The bug did not affect correct templates. Fixes issue 3267.

Patch Set 1 #

Patch Set 2 : diff -r 701af83040ac https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	src/pkg/text/template/exec.go	View		2 chunks	+6 lines, -1 line	0 comments	Download
	M	src/pkg/text/template/exec_test.go	View		3 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2012-03-26 01:10:19 UTC) #1

12 years ago (2012-04-03 01:45:00 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=c007925a75c6 ***

text/template: pipelined arg was not typechecked
Without this fix, an erroneous template causes a panic; should be caught safely.
The bug did not affect correct templates.

Fixes issue 3267.

R=golang-dev, dsymonds, rsc
CC=golang-dev
http://codereview.appspot.com/5900065

Expand All Messages | Collapse All Messages