Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 5900061: code review 5900061: cmd/go: allow underscores in tool name (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by minux1
Modified:
12 years, 11 months ago
Reviewers:
rsc
CC:
golang-dev, r
Visibility:
Public.

Description

cmd/go: allow underscores in tool name Otherwise we can't invoke go_bootstrap directly.

Patch Set 1 #

Patch Set 2 : diff -r ee5c7588cb7f https://code.google.com/p/go/ #

Patch Set 3 : diff -r ee5c7588cb7f https://code.google.com/p/go/ #

Patch Set 4 : diff -r e03e5e19e681 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/cmd/go/tool.go View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 11 months ago (2012-03-25 18:11:26 UTC) #1
r
LGTM
12 years, 11 months ago (2012-03-25 21:07:22 UTC) #2
minux1
*** Submitted as http://code.google.com/p/go/source/detail?r=a50b793f143b *** cmd/go: allow underscores in tool name Otherwise we can't invoke ...
12 years, 11 months ago (2012-03-26 02:01:26 UTC) #3
rsc
Okay, but why are you running go tool go_bootstrap?
12 years, 11 months ago (2012-03-26 12:59:43 UTC) #4
minux1
12 years, 11 months ago (2012-03-26 13:47:16 UTC) #5
On Mon, Mar 26, 2012 at 8:59 PM, Russ Cox <rsc@golang.org> wrote:

> Okay, but why are you running go tool go_bootstrap?
>
I'm debugging cmd/go, and suddenly I broke 'go install', so the only way to
get cmd/go back
is to use 'go tool go_bootstrap install cmd/go' if I don't want to want for
cmd/dist rebuilding
(nearly) everything.
I should have saved a backup of cmd/go.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b