Issue 5900061: code review 5900061: cmd/go: allow underscores in tool name

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5900061: code review 5900061: cmd/go: allow underscores in tool name (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by minux1

Modified:
12 years, 11 months ago

Reviewers:
rsc

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/go: allow underscores in tool name Otherwise we can't invoke go_bootstrap directly.

Patch Set 1 #

Patch Set 2 : diff -r ee5c7588cb7f https://code.google.com/p/go/ #

Patch Set 3 : diff -r ee5c7588cb7f https://code.google.com/p/go/ #

Patch Set 4 : diff -r e03e5e19e681 https://code.google.com/p/go/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/cmd/go/tool.go	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 11 months ago (2012-03-25 18:11:26 UTC) #1

minux1

*** Submitted as http://code.google.com/p/go/source/detail?r=a50b793f143b *** cmd/go: allow underscores in tool name Otherwise we can't invoke ...

12 years, 11 months ago (2012-03-26 02:01:26 UTC) #3

minux1

12 years, 11 months ago (2012-03-26 13:47:16 UTC) #5

On Mon, Mar 26, 2012 at 8:59 PM, Russ Cox <rsc@golang.org> wrote:

> Okay, but why are you running go tool go_bootstrap?
>
I'm debugging cmd/go, and suddenly I broke 'go install', so the only way to
get cmd/go back
is to use 'go tool go_bootstrap install cmd/go' if I don't want to want for
cmd/dist rebuilding
(nearly) everything.
I should have saved a backup of cmd/go.

Expand All Messages | Collapse All Messages