LGTM On Mar 23, 2012 4:11 PM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > > Message: ...
12 years, 11 months ago
(2012-03-23 23:12:24 UTC)
#2
LGTM
On Mar 23, 2012 4:11 PM, <r@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> docs/articles/wiki: minor fixes
>
> Please review this at
http://codereview.appspot.com/**5900046/<http://codereview.appspot.com/5900046/>
>
> Affected files:
> doc/articles/wiki/wiki.html
>
>
> Index: doc/articles/wiki/wiki.html
> ==============================**==============================**=======
> --- a/doc/articles/wiki/wiki.html
> +++ b/doc/articles/wiki/wiki.html
> @@ -36,7 +36,7 @@
> </p>
>
> <p>
> -Make a new directory for this tutorial and cd to it:
> +Make a new directory for this tutorial inside your <code>GOPATH</code>
> and cd to it:
> </p>
>
> <pre>
> @@ -551,8 +551,8 @@
>
> <p>
> There is an inefficiency in this code: <code>renderTemplate</code> calls
> -<code>ParseFile</code> every time a page is rendered.
> -A better approach would be to call <code>ParseFile</code> once for each
> +<code>ParseFiles</code> every time a page is rendered.
> +A better approach would be to call <code>ParseFiles</code> once for each
> template at program initialization, and store the resultant
> <code>*Template</code> values in a data structure for later use.
> </p>
>
>
>
Issue 5900046: code review 5900046: docs/articles/wiki: minor fixes
(Closed)
Created 12 years, 11 months ago by r
Modified 12 years, 11 months ago
Reviewers:
Base URL:
Comments: 0