Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(117)

Issue 58890045: code review 58890045: go.net/publicsuffix: update table to latest list from p... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by nigeltao
Modified:
11 years, 1 month ago
Reviewers:
volker.dobler
CC:
volker.dobler, golang-codereviews
Visibility:
Public.

Description

go.net/publicsuffix: update table to latest list from publicsuffix.org. Also add a sanity check for the erroneous all-caps "TOKYO" that was fixed in http://hg.mozilla.org/mozilla-central/rev/e85f83f352de

Patch Set 1 #

Patch Set 2 : diff -r 93f5aef8cb25 https://code.google.com/p/go.net #

Patch Set 3 : diff -r 93f5aef8cb25 https://code.google.com/p/go.net #

Patch Set 4 : diff -r 93f5aef8cb25 https://code.google.com/p/go.net #

Patch Set 5 : diff -r 93f5aef8cb25 https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7555 lines, -6979 lines) Patch
publicsuffix/gen.go View 1 3 chunks +9 lines, -0 lines 0 comments Download
publicsuffix/table.go View 1 4 chunks +7119 lines, -6925 lines 0 comments Download
publicsuffix/table_test.go View 1 49 chunks +427 lines, -54 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello dr.volker.dobler@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net
11 years, 1 month ago (2014-02-10 00:50:23 UTC) #1
volker.dobler
LGTM On Mon, Feb 10, 2014 at 1:50 AM, <nigeltao@golang.org> wrote: > Reviewers: volker.dobler, > ...
11 years, 1 month ago (2014-02-10 21:59:47 UTC) #2
nigeltao
11 years, 1 month ago (2014-02-11 01:08:39 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=a410c0c2ab2e&repo=net ***

go.net/publicsuffix: update table to latest list from publicsuffix.org.

Also add a sanity check for the erroneous all-caps "TOKYO" that was
fixed in http://hg.mozilla.org/mozilla-central/rev/e85f83f352de

LGTM=dr.volker.dobler
R=dr.volker.dobler
CC=golang-codereviews
https://codereview.appspot.com/58890045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b