code review 5885056: path/filepath: windows drive letter cannot be a digit

path/filepath: windows drive letter cannot be a digit

[brainman, 2012-03-23 04:55:11]

Hello golang-dev@googlegroups.com (cc: mattn.jp@gmail.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-03-23 04:56:07]

LGTM

[brainman, 2012-03-23 04:57:27]

*** Submitted as http://code.google.com/p/go/source/detail?r=e3bcedc9400a ***

path/filepath: windows drive letter cannot be a digit

R=golang-dev, r
CC=golang-dev, mattn.jp
http://codereview.appspot.com/5885056

[mattn, 2012-03-23 06:08:03]

LGTM

On 2012/03/23 04:57:27, brainman wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=e3bcedc9400a ***
> 
> path/filepath: windows drive letter cannot be a digit
> 
> R=golang-dev, r
> CC=golang-dev, mattn.jp
> http://codereview.appspot.com/5885056

[aram, 2012-03-23 08:00:30]

Nothing against this change, just a small nitpick. Drive letters *can* be
digits:

  C:\Windows\system32>cd 1:

  1:\>
  1:\>
  1:\>dir
   Volume in drive 1 is NTOS
   Volume Serial Number is 3C16-C258

   Directory of 1:\

  04.10.2011  22:26             1.024 .rnd
  15.03.2012  02:11    <DIR>          1
  27.08.2011  21:52    <DIR>          acme
  29.08.2011  16:13    <DIR>          aircrack-ng
  07.12.2011  15:13    <DIR>          curl
  30.08.2011  14:46    <DIR>          dd
  14.03.2012  23:00    <DIR>          go
  13.07.2011  03:09    <DIR>          ida61
  19.12.2009  14:41    <DIR>          inferno
  27.08.2011  21:12    <DIR>          Intel
  06.11.2011  01:01    <DIR>          Lexmark
  19.03.2012  18:07    <DIR>          Program Files
  19.03.2012  16:14    <DIR>          Program Files (x86)
  13.12.2011  16:53    <DIR>          Python32
  15.03.2012  12:55    <DIR>          src
  13.02.2012  19:29    <DIR>          SysInt
  10.11.2011  16:41    <DIR>          totalcmd
  11.02.2012  14:50    <DIR>          Users
  30.01.2012  10:08    <DIR>          vm
  15.03.2012  15:40    <DIR>          Windows
                 1 File(s)          1.024 bytes
                19 Dir(s)  32.564.121.600 bytes free

They can even be other symbols, like Σ,

  1:\>dir σ:
   Volume in drive Σ is NTOS
   Volume Serial Number is 3C16-C258

   Directory of Σ:\

  04.10.2011  22:26             1.024 .rnd
  15.03.2012  02:11    <DIR>          1
  27.08.2011  21:52    <DIR>          acme
  29.08.2011  16:13    <DIR>          aircrack-ng
  07.12.2011  15:13    <DIR>          curl
  30.08.2011  14:46    <DIR>          dd
  14.03.2012  23:00    <DIR>          go
  13.07.2011  03:09    <DIR>          ida61
  19.12.2009  14:41    <DIR>          inferno
  27.08.2011  21:12    <DIR>          Intel
  06.11.2011  01:01    <DIR>          Lexmark
  19.03.2012  18:07    <DIR>          Program Files
  19.03.2012  16:14    <DIR>          Program Files (x86)
  13.12.2011  16:53    <DIR>          Python32
  15.03.2012  12:55    <DIR>          src
  13.02.2012  19:29    <DIR>          SysInt
  10.11.2011  16:41    <DIR>          totalcmd
  11.02.2012  14:50    <DIR>          Users
  30.01.2012  10:08    <DIR>          vm
  15.03.2012  15:40    <DIR>          Windows
                 1 File(s)          1.024 bytes
                19 Dir(s)  32.564.031.488 bytes free

It even swapped the case of my small case σ to Σ.

I created all of the above problematically, I don't believe it can be done from
the shell.

[r2, 2012-03-23 09:03:30]

My fault for LGTM'ing instead of "after Go 1"ing.

Not sure it's worth rolling back, though. As you say, it requires tricks, and
from my explorations on the web it seems most people  and things assume it's an
upper-case letter. I don't think it's a mistake to continue that assumption.

For instance,
http://windows.microsoft.com/en-US/windows-vista/Change-add-or-remove-a-drive...
says,

	You can assign the letters C through Z to each drive on your computer.

-rob

[aram, 2012-03-23 09:05:38]

Yes, I agree it's not worth rolling back.