code review 5877062: misc/dist: make godoc shortcut work

misc/dist: make godoc shortcut work

[adg, 2012-03-23 01:43:43]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[adg, 2012-03-23 01:44:39]

*** Submitted as http://code.google.com/p/go/source/detail?r=bce220d03774 ***

misc/dist: make godoc shortcut work

R=golang-dev
CC=golang-dev
http://codereview.appspot.com/5877062

[Joe Poirier, 2012-03-23 02:04:57]

On Thu, Mar 22, 2012 at 8:43 PM,  <adg@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> misc/dist: make godoc shortcut work
>
> Please review this at http://codereview.appspot.com/5877062/
>
> Affected files:
>  M misc/dist/windows/installer.wxs
>
>
> Index: misc/dist/windows/installer.wxs
> ===================================================================
> --- a/misc/dist/windows/installer.wxs
> +++ b/misc/dist/windows/installer.wxs
> @@ -78,7 +78,7 @@
>         Name="GoDocServer"
>         Description="Starts the Go documentation server
> (http://localhost:6060)"
>         Show="minimized"
> -        Arguments='/c start "Godoc Server http://localhost:6060"
> /d"[INSTALLDIR]bin" godoc.exe -http=:6060 -goroot="[INSTALLDIR]"
> -path="%GOPATH%" &amp;&amp; start http://localhost:6060'
> +        Arguments='/c start "Godoc Server http://localhost:6060"
> "[INSTALLDIR]bin\godoc.exe" -http=localhost:6060 -goroot="[INSTALLDIR]\."
> &amp;&amp; start http://localhost:6060'
>         Icon="gopher.ico"
>         Target="[%ComSpec]" />
>     <Shortcut
>
>
 A bit late I know.

Does that work?

It should probably look like this
Arguments='/c "start "Godoc Server http://localhost:6060"
/d"[INSTALLDIR]bin" godoc.exe -http=:6060 &amp;&amp; start
http://localhost:6060"'

- get rid of godoc (you set goroot) and gopath (godoc doesn't like
single back slashes right now)
- the concatenated command string, everything after /c, needs to be in quotes
- I don't think you can get rid of the /d then just append godoc.exe

-joe

[adg, 2012-03-23 02:06:19]

It works for me. You can test it, the binaries are up:
http://code.google.com/p/go/downloads/list

On 23 March 2012 13:04, Joseph Poirier <jdpoirier@gmail.com> wrote:
> On Thu, Mar 22, 2012 at 8:43 PM,  <adg@golang.org> wrote:
>> Reviewers: golang-dev_googlegroups.com,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://go.googlecode.com/hg
>>
>>
>> Description:
>> misc/dist: make godoc shortcut work
>>
>> Please review this at http://codereview.appspot.com/5877062/
>>
>> Affected files:
>>  M misc/dist/windows/installer.wxs
>>
>>
>> Index: misc/dist/windows/installer.wxs
>> ===================================================================
>> --- a/misc/dist/windows/installer.wxs
>> +++ b/misc/dist/windows/installer.wxs
>> @@ -78,7 +78,7 @@
>>         Name="GoDocServer"
>>         Description="Starts the Go documentation server
>> (http://localhost:6060)"
>>         Show="minimized"
>> -        Arguments='/c start "Godoc Server http://localhost:6060"
>> /d"[INSTALLDIR]bin" godoc.exe -http=:6060 -goroot="[INSTALLDIR]"
>> -path="%GOPATH%" &amp;&amp; start http://localhost:6060'
>> +        Arguments='/c start "Godoc Server http://localhost:6060"
>> "[INSTALLDIR]bin\godoc.exe" -http=localhost:6060 -goroot="[INSTALLDIR]\."
>> &amp;&amp; start http://localhost:6060'
>>         Icon="gopher.ico"
>>         Target="[%ComSpec]" />
>>     <Shortcut
>>
>>
>  A bit late I know.
>
> Does that work?
>
> It should probably look like this
> Arguments='/c "start "Godoc Server http://localhost:6060"
> /d"[INSTALLDIR]bin" godoc.exe -http=:6060 &amp;&amp; start
> http://localhost:6060"'
>
> - get rid of godoc (you set goroot) and gopath (godoc doesn't like
> single back slashes right now)
> - the concatenated command string, everything after /c, needs to be in quotes
> - I don't think you can get rid of the /d then just append godoc.exe
>
> -joe

[Joe Poirier, 2012-03-23 02:15:25]

On Thu, Mar 22, 2012 at 9:05 PM, Andrew Gerrand <adg@golang.org> wrote:
> It works for me. You can test it, the binaries are up:
> http://code.google.com/p/go/downloads/list
>
It depends what you run it on 2k\XP\7, 7 seems to be the most
forgiving, but I don't think it's a big deal.
-joe

[Joe Poirier, 2012-03-23 02:44:19]

On Thu, Mar 22, 2012 at 9:14 PM, Joseph Poirier <jdpoirier@gmail.com> wrote:
> On Thu, Mar 22, 2012 at 9:05 PM, Andrew Gerrand <adg@golang.org> wrote:
>> It works for me. You can test it, the binaries are up:
>> http://code.google.com/p/go/downloads/list
>>
> It depends what you run it on 2k\XP\7, 7 seems to be the most
> forgiving, but I don't think it's a big deal.
> -joe

Just checked, works on all three systems.

LOL - from the Microsoft documentation

Using multiple commands
You can use multiple commands separated by the command separator &&
for string, but you must enclose them in quotation marks (for example,
"command&&command&&command").


so much for following directions. :)

[adg, 2012-03-23 02:50:30]

Thanks very much for testing it. The bug I found in godoc was that it
didn't like GOROOTs with a trailing slash. Will file an issue.

On Friday, March 23, 2012, Joseph Poirier wrote:

> On Thu, Mar 22, 2012 at 9:14 PM, Joseph Poirier
<jdpoirier@gmail.com<javascript:;>>
> wrote:
> > On Thu, Mar 22, 2012 at 9:05 PM, Andrew Gerrand
<adg@golang.org<javascript:;>>
> wrote:
> >> It works for me. You can test it, the binaries are up:
> >> http://code.google.com/p/go/downloads/list
> >>
> > It depends what you run it on 2k\XP\7, 7 seems to be the most
> > forgiving, but I don't think it's a big deal.
> > -joe
>
> Just checked, works on all three systems.
>
> LOL - from the Microsoft documentation
>
> Using multiple commands
> You can use multiple commands separated by the command separator &&
> for string, but you must enclose them in quotation marks (for example,
> "command&&command&&command").
>
>
> so much for following directions. :)
>