code review 5877059: misc/dist: updates to installer script

misc/dist: updates to installer script

Now sets GOROOT.

Fixes issue 3287.
Fixes issue 3361.

[adg, 2012-03-23 00:26:03]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[adg, 2012-03-23 00:48:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=0e050c9637fb ***

misc/dist: updates to installer script

Now sets GOROOT.

Fixes issue 3287.
Fixes issue 3361.

R=golang-dev
CC=golang-dev
http://codereview.appspot.com/5877059

[adg, 2012-03-23 00:49:44]

Submitting this for the weekly. It works for me. Let me know if I did
anything wrong.

[Joe Poirier, 2012-03-23 00:56:17]

LGTM

with just a single comment

http://codereview.appspot.com/5877059/diff/1/misc/dist/windows/installer.wxs
File misc/dist/windows/installer.wxs (right):

http://codereview.appspot.com/5877059/diff/1/misc/dist/windows/installer.wxs#...
misc/dist/windows/installer.wxs:81: Arguments='/c start "Godoc Server
http://localhost:6060" /d"[INSTALLDIR]bin" godoc.exe -http=:6060
-goroot="[INSTALLDIR]" -path="%GOPATH%" && start http://localhost:6060'
this needs to have an open quote at the first start command and an end quote at
the end of 6060.  e.g.   '/c "start .... 6060"'   <- hard to see but it's a
double and single quote together.

[adg, 2012-03-23 01:49:50]

On 23 March 2012 11:56,  <jdpoirier@gmail.com> wrote:
> LGTM
>
> with just a single comment
>
>
> http://codereview.appspot.com/5877059/diff/1/misc/dist/windows/installer.wxs
> File misc/dist/windows/installer.wxs (right):
>
>
http://codereview.appspot.com/5877059/diff/1/misc/dist/windows/installer.wxs#...
> misc/dist/windows/installer.wxs:81: Arguments='/c start "Godoc Server
>
> http://localhost:6060" /d"[INSTALLDIR]bin" godoc.exe -http=:6060
> -goroot="[INSTALLDIR]" -path="%GOPATH%" &amp;&amp; start
> http://localhost:6060'
> this needs to have an open quote at the first start command and an end
> quote at the end of 6060.  e.g.   '/c "start .... 6060"'   <- hard to
> see but it's a double and single quote together.

Really? That doesn't make much sense to me. There were some problems
with the shortcut, though, which should now be fixed.

Andrew

[Joe Poirier, 2012-03-23 02:10:56]

On Thu, Mar 22, 2012 at 8:49 PM, Andrew Gerrand <adg@golang.org> wrote:
> On 23 March 2012 11:56,  <jdpoirier@gmail.com> wrote:
>> LGTM
>>
>> with just a single comment
>>
>>
>> http://codereview.appspot.com/5877059/diff/1/misc/dist/windows/installer.wxs
>> File misc/dist/windows/installer.wxs (right):
>>
>>
http://codereview.appspot.com/5877059/diff/1/misc/dist/windows/installer.wxs#...
>> misc/dist/windows/installer.wxs:81: Arguments='/c start "Godoc Server
>>
>> http://localhost:6060" /d"[INSTALLDIR]bin" godoc.exe -http=:6060
>> -goroot="[INSTALLDIR]" -path="%GOPATH%" &amp;&amp; start
>> http://localhost:6060'
>> this needs to have an open quote at the first start command and an end
>> quote at the end of 6060.  e.g.   '/c "start .... 6060"'   <- hard to
>> see but it's a double and single quote together.
>
> Really? That doesn't make much sense to me. There were some problems
> with the shortcut, though, which should now be fixed.
>
> Andrew

The problem is is that godoc doesn't like the single back slashes in
the goroot path.
The Arguments variable requires a quoted string and the shortcut field
requires everything after the /c to be in quotes.
-joe