Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 5876044: code review 5876044: cmd/gc: when expanding append inline, preserve arguments (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by iant
Modified:
12 years, 11 months ago
Reviewers:
iant2, rsc, bradfitz
CC:
golang-dev, gri, lvd1, r
Visibility:
Public.

Description

cmd/gc: when expanding append inline, preserve arguments Fixes issue 3369.

Patch Set 1 #

Patch Set 2 : diff -r 0ec67c4df6bd https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M src/cmd/gc/walk.c View 1 1 chunk +6 lines, -0 lines 0 comments Download
A test/fixedbugs/bug428.go View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 11
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 11 months ago (2012-03-21 22:59:34 UTC) #1
gri
LGTM
12 years, 11 months ago (2012-03-21 23:16:09 UTC) #2
iant
Luuk, since rsc is on vacation, can you take a quick look at this?
12 years, 11 months ago (2012-03-21 23:54:56 UTC) #3
r
LGTM
12 years, 11 months ago (2012-03-22 02:18:08 UTC) #4
lvd1
cheapexpr is supposed to be or quickly become a noop, the real fix should be ...
12 years, 11 months ago (2012-03-22 10:14:42 UTC) #5
lvd1
On Thu, Mar 22, 2012 at 11:14, Luuk van Dijk <lvd@golang.org> wrote: > cheapexpr is ...
12 years, 11 months ago (2012-03-22 12:46:07 UTC) #6
lvd1
On Thu, Mar 22, 2012 at 13:46, Luuk van Dijk <lvd@golang.org> wrote: > > On ...
12 years, 11 months ago (2012-03-22 12:54:48 UTC) #7
iant
*** Submitted as http://code.google.com/p/go/source/detail?r=75162220fd1e *** cmd/gc: when expanding append inline, preserve arguments Fixes issue 3369. ...
12 years, 11 months ago (2012-03-22 16:44:35 UTC) #8
bradfitz
s/along/alone/ typo also, why spaces around one the = in one assignment but not the ...
12 years, 11 months ago (2012-03-22 16:53:22 UTC) #9
iant2
Brad Fitzpatrick <bradfitz@golang.org> writes: > s/along/alone/ typo > > also, why spaces around one the ...
12 years, 11 months ago (2012-03-22 17:58:05 UTC) #10
rsc
12 years, 11 months ago (2012-03-26 14:04:19 UTC) #11
LGTM

Ouch, thank you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b