Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(136)

Issue 5874058: code review 5874058: doc/articles/c_go_cgo.html: correct "C" comment to ment... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by iant
Modified:
12 years, 11 months ago
Reviewers:
CC:
r, gri, adg, golang-dev
Visibility:
Public.

Description

doc/articles/c_go_cgo.html: correct "C" comment to mention #cgo Also fix invalid apostrophe characters.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 0d4324e5a047 https://go.googlecode.com/hg/ #

Total comments: 6

Patch Set 3 : diff -r 0d4324e5a047 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r 0d4324e5a047 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 1bb581757a7e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -12 lines) Patch
M doc/articles/c_go_cgo.html View 1 2 3 7 chunks +32 lines, -12 lines 0 comments Download

Messages

Total messages: 11
iant
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 11 months ago (2012-03-22 21:16:28 UTC) #1
gri
LGTM leaving for r
12 years, 11 months ago (2012-03-22 21:21:43 UTC) #2
r
http://codereview.appspot.com/5874058/diff/1/doc/articles/c_go_cgo.html File doc/articles/c_go_cgo.html (right): http://codereview.appspot.com/5874058/diff/1/doc/articles/c_go_cgo.html#newcode80 doc/articles/c_go_cgo.html:80: statement, but they can be any C code. i ...
12 years, 11 months ago (2012-03-22 21:35:04 UTC) #3
adg
http://codereview.appspot.com/5874058/diff/1/doc/articles/c_go_cgo.html File doc/articles/c_go_cgo.html (right): http://codereview.appspot.com/5874058/diff/1/doc/articles/c_go_cgo.html#newcode80 doc/articles/c_go_cgo.html:80: statement, but they can be any C code. On ...
12 years, 11 months ago (2012-03-22 22:20:27 UTC) #4
iant
Good point. PTAL.
12 years, 11 months ago (2012-03-22 23:06:15 UTC) #5
r
http://codereview.appspot.com/5874058/diff/4/doc/articles/c_go_cgo.html File doc/articles/c_go_cgo.html (right): http://codereview.appspot.com/5874058/diff/4/doc/articles/c_go_cgo.html#newcode81 doc/articles/c_go_cgo.html:81: if your program uses any //export directives, then the ...
12 years, 11 months ago (2012-03-22 23:08:58 UTC) #6
iant
PTAL http://codereview.appspot.com/5874058/diff/4/doc/articles/c_go_cgo.html File doc/articles/c_go_cgo.html (right): http://codereview.appspot.com/5874058/diff/4/doc/articles/c_go_cgo.html#newcode81 doc/articles/c_go_cgo.html:81: if your program uses any //export directives, then ...
12 years, 11 months ago (2012-03-22 23:18:12 UTC) #7
r
http://codereview.appspot.com/5874058/diff/1002/doc/articles/c_go_cgo.html File doc/articles/c_go_cgo.html (right): http://codereview.appspot.com/5874058/diff/1002/doc/articles/c_go_cgo.html#newcode79 doc/articles/c_go_cgo.html:79: the package. In this case those lines are just ...
12 years, 11 months ago (2012-03-22 23:20:22 UTC) #8
iant
PTAL http://codereview.appspot.com/5874058/diff/1002/doc/articles/c_go_cgo.html File doc/articles/c_go_cgo.html (right): http://codereview.appspot.com/5874058/diff/1002/doc/articles/c_go_cgo.html#newcode79 doc/articles/c_go_cgo.html:79: the package. In this case those lines are ...
12 years, 11 months ago (2012-03-23 00:01:35 UTC) #9
r
LGTM
12 years, 11 months ago (2012-03-23 00:33:29 UTC) #10
iant
12 years, 11 months ago (2012-03-23 00:44:31 UTC) #11
*** Submitted as http://code.google.com/p/go/source/detail?r=6b2ffd34cc40 ***

doc/articles/c_go_cgo.html: correct "C" comment to mention #cgo

Also fix invalid apostrophe characters.

R=r, gri, adg
CC=golang-dev
http://codereview.appspot.com/5874058
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b