code review 5874058: doc/articles/c_go_cgo.html: correct "C" comment to ment...

doc/articles/c_go_cgo.html: correct "C" comment to mention #cgo

Also fix invalid apostrophe characters.

[iant, 2012-03-22 21:16:28]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2012-03-22 21:21:43]

LGTM

leaving for r

[r, 2012-03-22 21:35:04]

http://codereview.appspot.com/5874058/diff/1/doc/articles/c_go_cgo.html
File doc/articles/c_go_cgo.html (right):

http://codereview.appspot.com/5874058/diff/1/doc/articles/c_go_cgo.html#newco...
doc/articles/c_go_cgo.html:80: statement, but they can be any C code.
i remember a complaint on the mailing list that you shouldn't declare variables
in these blocks.

[adg, 2012-03-22 22:20:27]

http://codereview.appspot.com/5874058/diff/1/doc/articles/c_go_cgo.html
File doc/articles/c_go_cgo.html (right):

http://codereview.appspot.com/5874058/diff/1/doc/articles/c_go_cgo.html#newco...
doc/articles/c_go_cgo.html:80: statement, but they can be any C code.
On 2012/03/22 21:35:04, r wrote:
> i remember a complaint on the mailing list that you shouldn't declare
variables
> in these blocks.

You cannot declare variables or functions in those blocks if you use //export
lines. That fact, and //export in general, are probably worth calling out in
this document.

[iant, 2012-03-22 23:06:15]

Good point.  PTAL.

[r, 2012-03-22 23:08:58]

http://codereview.appspot.com/5874058/diff/4/doc/articles/c_go_cgo.html
File doc/articles/c_go_cgo.html (right):

http://codereview.appspot.com/5874058/diff/4/doc/articles/c_go_cgo.html#newco...
doc/articles/c_go_cgo.html:81: if your program uses any //export directives,
then the C code may only
<code> on the //export

http://codereview.appspot.com/5874058/diff/4/doc/articles/c_go_cgo.html#newco...
doc/articles/c_go_cgo.html:88: linker for the C parts of the package.  The
//export directives are
ditto

http://codereview.appspot.com/5874058/diff/4/doc/articles/c_go_cgo.html#newco...
doc/articles/c_go_cgo.html:90: in the <a href="/cmd/cgo/">cgo documentation</a>.
things are a bit scrambled. can you reorder so the //export stuff is together?

[iant, 2012-03-22 23:18:12]

PTAL

http://codereview.appspot.com/5874058/diff/4/doc/articles/c_go_cgo.html
File doc/articles/c_go_cgo.html (right):

http://codereview.appspot.com/5874058/diff/4/doc/articles/c_go_cgo.html#newco...
doc/articles/c_go_cgo.html:81: if your program uses any //export directives,
then the C code may only
On 2012/03/22 23:08:58, r wrote:
> <code> on the //export

Done.

http://codereview.appspot.com/5874058/diff/4/doc/articles/c_go_cgo.html#newco...
doc/articles/c_go_cgo.html:88: linker for the C parts of the package.  The
//export directives are
On 2012/03/22 23:08:58, r wrote:
> ditto

Done.

http://codereview.appspot.com/5874058/diff/4/doc/articles/c_go_cgo.html#newco...
doc/articles/c_go_cgo.html:90: in the <a href="/cmd/cgo/">cgo documentation</a>.
On 2012/03/22 23:08:58, r wrote:
> things are a bit scrambled. can you reorder so the //export stuff is together?

Rearranged text.

[r, 2012-03-22 23:20:22]

http://codereview.appspot.com/5874058/diff/1002/doc/articles/c_go_cgo.html
File doc/articles/c_go_cgo.html (right):

http://codereview.appspot.com/5874058/diff/1002/doc/articles/c_go_cgo.html#ne...
doc/articles/c_go_cgo.html:79: the package.  In this case those lines are just a
single #include
<code> the #XXX pieces.

http://codereview.appspot.com/5874058/diff/1002/doc/articles/c_go_cgo.html#ne...
doc/articles/c_go_cgo.html:87: directives, then the C code may only include
declarations
which C code?

[iant, 2012-03-23 00:01:35]

PTAL

http://codereview.appspot.com/5874058/diff/1002/doc/articles/c_go_cgo.html
File doc/articles/c_go_cgo.html (right):

http://codereview.appspot.com/5874058/diff/1002/doc/articles/c_go_cgo.html#ne...
doc/articles/c_go_cgo.html:79: the package.  In this case those lines are just a
single #include
On 2012/03/22 23:20:22, r wrote:
> <code> the #XXX pieces.

Done.

http://codereview.appspot.com/5874058/diff/1002/doc/articles/c_go_cgo.html#ne...
doc/articles/c_go_cgo.html:87: directives, then the C code may only include
declarations
On 2012/03/22 23:20:22, r wrote:
> which C code?

Done.

[r, 2012-03-23 00:33:29]

LGTM

[iant, 2012-03-23 00:44:31]

*** Submitted as http://code.google.com/p/go/source/detail?r=6b2ffd34cc40 ***

doc/articles/c_go_cgo.html: correct "C" comment to mention #cgo

Also fix invalid apostrophe characters.

R=r, gri, adg
CC=golang-dev
http://codereview.appspot.com/5874058