code review 5869049: test: use testlib in a few more cases (part 2)

test: use testlib in a few more cases (part 2)
        Introduced "runoutput" cmd for running generated program

[minux1, 2012-03-21 18:19:05]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[minux1, 2012-03-21 18:20:16]

There are a few other tests that can be converted to use "run|run".
I just want to be sure if this approach is OK before changing the others.

[iant, 2012-03-21 18:31:05]

The general approach looks OK but I think we may want to wait until after Go 1. 
The last patch was straightforward, this one, not so much.

[minux1, 2012-04-19 16:46:29]

ping.

[bradfitz, 2012-04-19 16:49:39]

What is "run|run"?  Or is it "run|run -"?  All the other ones have obvious
names like "build", "compile", "run".

Can you find a better name, or at least write some comments?


On Thu, Apr 19, 2012 at 9:46 AM, <minux.ma@gmail.com> wrote:

> ping.
>
>
http://codereview.appspot.com/**5869049/<http://codereview.appspot.com/5869049/>
>

[minux1, 2012-04-19 16:53:24]

On 2012/04/19 16:49:39, bradfitz wrote:
> What is "run|run"?  Or is it "run|run -"?  All the other ones have obvious
> names like "build", "compile", "run".
run|run means this run this tests and treat the output as a new go program, and
run it (a normal shell pipeline).

run|run - is just for the testlib.

Of course, if you want a new command, I'm glad to do so.

[iant, 2012-04-19 20:22:47]

Personally I would prefer to see a clearer single name rather than go back to
shell syntax.

[minux1, 2012-04-19 20:46:00]

On Fri, Apr 20, 2012 at 4:22 AM, <iant@golang.org> wrote:

> Personally I would prefer to see a clearer single name rather than go
> back to shell syntax.
>
how about runGenerated? I used 'run|run' because I didn't know any better
name...
so any suggestions welcome.

[iant, 2012-04-19 21:07:00]

Oh, you want suggestions....  I'm terrible at names.  How about just "runrun"?

[remyoudompheng, 2012-04-19 23:17:14]

I suggest "runoutput".

[bradfitz, 2012-04-19 23:22:07]

SGTM

On Thu, Apr 19, 2012 at 4:17 PM, <remyoudompheng@gmail.com> wrote:

> I suggest "runoutput".
>
>
http://codereview.appspot.com/**5869049/<http://codereview.appspot.com/5869049/>
>

[minux1, 2012-04-20 12:08:39]

PTAL.

[bradfitz, 2012-04-20 15:26:56]

LGTM

On Fri, Apr 20, 2012 at 5:08 AM, <minux.ma@gmail.com> wrote:

> PTAL.
>
>
http://codereview.appspot.com/**5869049/<http://codereview.appspot.com/5869049/>
>

[iant, 2012-04-20 15:44:39]

LGTM

[minux1, 2012-04-20 15:46:00]

*** Submitted as http://code.google.com/p/go/source/detail?r=952bd8dc8259 ***

test: use testlib in a few more cases (part 2)
        Introduced "runoutput" cmd for running generated program

R=golang-dev, iant, bradfitz, remyoudompheng
CC=golang-dev
http://codereview.appspot.com/5869049