code review 5868048: test: use testlib in a few more cases

test: use testlib in a few more cases
        Introduce a new skip cmd.

[minux1, 2012-03-21 16:56:59]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2012-03-21 16:59:58]

LGTM but wait for iant to see if gccgo is cool with that new errorcheck.


On Wed, Mar 21, 2012 at 9:56 AM, <minux.ma@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> test: use testlib in a few more cases
>        Introduce a new skip cmd.
>
> Please review this at
http://codereview.appspot.com/**5868048/<http://codereview.appspot.com/5868048/>
>
> Affected files:
>  M test/cmplxdivide.c
>  M test/cmplxdivide1.go
>  M test/ddd2.go
>  M test/fixedbugs/bug223.go
>  M test/import2.go
>  M test/interface/embed0.go
>  M test/interface/private1.go
>  M test/interface/recursive1.go
>  M test/method4a.go
>  M test/run.go
>  M test/testlib
>
>
> Index: test/cmplxdivide.c
> ==============================**==============================**=======
> --- a/test/cmplxdivide.c
> +++ b/test/cmplxdivide.c
> @@ -51,6 +51,7 @@
>        int i, j, k, l;
>        double complex n, d, q;
>
> +       printf("// skip\n");
>        printf("// # generated by cmplxdivide.c\n");
>        printf("\n");
>        printf("package main\n");
> Index: test/cmplxdivide1.go
> ==============================**==============================**=======
> --- a/test/cmplxdivide1.go
> +++ b/test/cmplxdivide1.go
> @@ -1,3 +1,4 @@
> +// skip
>  // # generated by cmplxdivide.c
>
>  package main
> Index: test/ddd2.go
> ==============================**==============================**=======
> --- a/test/ddd2.go
> +++ b/test/ddd2.go
> @@ -1,4 +1,4 @@
> -// true
> +// skip
>
>  // Copyright 2010 The Go Authors.  All rights reserved.
>  // Use of this source code is governed by a BSD-style
> Index: test/fixedbugs/bug223.go
> ==============================**==============================**=======
> --- a/test/fixedbugs/bug223.go
> +++ b/test/fixedbugs/bug223.go
> @@ -1,4 +1,4 @@
> -// (! $G $D/$F.go) | grep 'initialization loop' >/dev/null || echo BUG:
> bug223
> +// errorcheck
>
>  // Copyright 2009 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
> @@ -18,4 +18,4 @@
>        }
>  }
>
> -var m = map[string]F{"f": f}
> +var m = map[string]F{"f": f} // ERROR "initialization loop"
> Index: test/import2.go
> ==============================**==============================**=======
> --- a/test/import2.go
> +++ b/test/import2.go
> @@ -1,4 +1,4 @@
> -// true  # used by import3
> +// skip # used by import3
>
>  // Copyright 2010 The Go Authors.  All rights reserved.
>  // Use of this source code is governed by a BSD-style
> Index: test/interface/embed0.go
> ==============================**==============================**=======
> --- a/test/interface/embed0.go
> +++ b/test/interface/embed0.go
> @@ -1,4 +1,4 @@
> -// true        # used by embed1.go
> +// skip # used by embed1.go
>
>  // Copyright 2009 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
> Index: test/interface/private1.go
> ==============================**==============================**=======
> --- a/test/interface/private1.go
> +++ b/test/interface/private1.go
> @@ -1,4 +1,4 @@
> -// true  # used by private.go
> +// skip # used by private.go
>
>  // Copyright 2011 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
> Index: test/interface/recursive1.go
> ==============================**==============================**=======
> --- a/test/interface/recursive1.go
> +++ b/test/interface/recursive1.go
> @@ -1,4 +1,4 @@
> -// true  # used by recursive2
> +// skip # used by recursive2
>
>  // Copyright 2012 The Go Authors.  All rights reserved.
>  // Use of this source code is governed by a BSD-style
> Index: test/method4a.go
> ==============================**==============================**=======
> --- a/test/method4a.go
> +++ b/test/method4a.go
> @@ -1,4 +1,4 @@
> -// true
> +// skip
>
>  // Copyright 2012 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
> Index: test/run.go
> ==============================**==============================**=======
> --- a/test/run.go
> +++ b/test/run.go
> @@ -1,4 +1,4 @@
> -// #ignore
> +// skip
>
>  // Copyright 2012 The Go Authors.  All rights reserved.
>  // Use of this source code is governed by a BSD-style
> @@ -172,7 +172,7 @@
>        donec       chan bool // closed when done
>
>        src    string
> -       action string // "compile", "build", "run", "errorcheck"
> +       action string // "compile", "build", "run", "errorcheck", "skip"
>
>        tempDir string
>        err     error
> @@ -253,6 +253,9 @@
>                fallthrough
>        case "compile", "build", "run", "errorcheck":
>                t.action = action
> +       case "skip":
> +               t.action = "skip"
> +               return
>        default:
>                t.err = skipError("skipped; unknown pattern: " + action)
>                t.action = "??"
> Index: test/testlib
> ==============================**==============================**=======
> --- a/test/testlib
> +++ b/test/testlib
> @@ -38,3 +38,7 @@
>  errorcheck() {
>        errchk $G -e $D/$F.go
>  }
> +
> +skip() {
> +       true
> +}
>
>
>

[iant2, 2012-03-21 17:51:08]

LGTM

minux.ma@gmail.com writes:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> test: use testlib in a few more cases
>         Introduce a new skip cmd.
>
> Please review this at http://codereview.appspot.com/5868048/
>
> Affected files:
>   M test/cmplxdivide.c
>   M test/cmplxdivide1.go
>   M test/ddd2.go
>   M test/fixedbugs/bug223.go
>   M test/import2.go
>   M test/interface/embed0.go
>   M test/interface/private1.go
>   M test/interface/recursive1.go
>   M test/method4a.go
>   M test/run.go
>   M test/testlib
>
>
> Index: test/cmplxdivide.c
> ===================================================================
> --- a/test/cmplxdivide.c
> +++ b/test/cmplxdivide.c
> @@ -51,6 +51,7 @@
>  	int i, j, k, l;
>  	double complex n, d, q;
>  	
> +	printf("// skip\n");
>  	printf("// # generated by cmplxdivide.c\n");
>  	printf("\n");
>  	printf("package main\n");
> Index: test/cmplxdivide1.go
> ===================================================================
> --- a/test/cmplxdivide1.go
> +++ b/test/cmplxdivide1.go
> @@ -1,3 +1,4 @@
> +// skip
>  // # generated by cmplxdivide.c
>
>  package main
> Index: test/ddd2.go
> ===================================================================
> --- a/test/ddd2.go
> +++ b/test/ddd2.go
> @@ -1,4 +1,4 @@
> -// true
> +// skip
>
>  // Copyright 2010 The Go Authors.  All rights reserved.
>  // Use of this source code is governed by a BSD-style
> Index: test/fixedbugs/bug223.go
> ===================================================================
> --- a/test/fixedbugs/bug223.go
> +++ b/test/fixedbugs/bug223.go
> @@ -1,4 +1,4 @@
> -// (! $G $D/$F.go) | grep 'initialization loop' >/dev/null || echo
> BUG: bug223
> +// errorcheck
>
>  // Copyright 2009 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
> @@ -18,4 +18,4 @@
>  	}
>  }
>
> -var m = map[string]F{"f": f}
> +var m = map[string]F{"f": f} // ERROR "initialization loop"
> Index: test/import2.go
> ===================================================================
> --- a/test/import2.go
> +++ b/test/import2.go
> @@ -1,4 +1,4 @@
> -// true  # used by import3
> +// skip # used by import3
>
>  // Copyright 2010 The Go Authors.  All rights reserved.
>  // Use of this source code is governed by a BSD-style
> Index: test/interface/embed0.go
> ===================================================================
> --- a/test/interface/embed0.go
> +++ b/test/interface/embed0.go
> @@ -1,4 +1,4 @@
> -// true	# used by embed1.go
> +// skip # used by embed1.go
>
>  // Copyright 2009 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
> Index: test/interface/private1.go
> ===================================================================
> --- a/test/interface/private1.go
> +++ b/test/interface/private1.go
> @@ -1,4 +1,4 @@
> -// true  # used by private.go
> +// skip # used by private.go
>
>  // Copyright 2011 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
> Index: test/interface/recursive1.go
> ===================================================================
> --- a/test/interface/recursive1.go
> +++ b/test/interface/recursive1.go
> @@ -1,4 +1,4 @@
> -// true  # used by recursive2
> +// skip # used by recursive2
>
>  // Copyright 2012 The Go Authors.  All rights reserved.
>  // Use of this source code is governed by a BSD-style
> Index: test/method4a.go
> ===================================================================
> --- a/test/method4a.go
> +++ b/test/method4a.go
> @@ -1,4 +1,4 @@
> -// true
> +// skip
>
>  // Copyright 2012 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
> Index: test/run.go
> ===================================================================
> --- a/test/run.go
> +++ b/test/run.go
> @@ -1,4 +1,4 @@
> -// #ignore
> +// skip
>
>  // Copyright 2012 The Go Authors.  All rights reserved.
>  // Use of this source code is governed by a BSD-style
> @@ -172,7 +172,7 @@
>  	donec       chan bool // closed when done
>
>  	src    string
> -	action string // "compile", "build", "run", "errorcheck"
> +	action string // "compile", "build", "run", "errorcheck", "skip"
>
>  	tempDir string
>  	err     error
> @@ -253,6 +253,9 @@
>  		fallthrough
>  	case "compile", "build", "run", "errorcheck":
>  		t.action = action
> +	case "skip":
> +		t.action = "skip"
> +		return
>  	default:
>  		t.err = skipError("skipped; unknown pattern: " + action)
>  		t.action = "??"
> Index: test/testlib
> ===================================================================
> --- a/test/testlib
> +++ b/test/testlib
> @@ -38,3 +38,7 @@
>  errorcheck() {
>  	errchk $G -e $D/$F.go
>  }
> +
> +skip() {
> +	true
> +}

[minux1, 2012-03-21 18:14:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=74edd315eec5 ***

test: use testlib in a few more cases
        Introduce a new skip cmd.

R=golang-dev, bradfitz, iant, iant
CC=golang-dev
http://codereview.appspot.com/5868048