code review 5866046: doc: remove reference to deleted os.ENOSPC

doc: remove reference to deleted os.ENOSPC

[bradfitz, 2012-03-20 23:30:52]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2012-03-20 23:33:04]

LGTM

On Tue, Mar 20, 2012 at 4:30 PM,  <bradfitz@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> doc: remove reference to deleted os.ENOSPC
>
> Please review this at http://codereview.appspot.com/5866046/
>
> Affected files:
>  M doc/effective_go.html
>
>
> Index: doc/effective_go.html
> ===================================================================
> --- a/doc/effective_go.html
> +++ b/doc/effective_go.html
> @@ -2715,7 +2715,7 @@
>     if err == nil {
>         return
>     }
> -    if e, ok := err.(*os.PathError); ok &amp;&amp; e.Err == os.ENOSPC {
> +    if e, ok := err.(*os.PathError); ok &amp;&amp; e.Err == syscall.ENOSPC
> {
>         deleteTempFiles()  // Recover some space.
>         continue
>     }
>
>

[r, 2012-03-20 23:35:17]

LGTM but maybe there's a better solution

http://codereview.appspot.com/5866046/diff/5001/doc/effective_go.html
File doc/effective_go.html (right):

http://codereview.appspot.com/5866046/diff/5001/doc/effective_go.html#newcode...
doc/effective_go.html:2718: if e, ok := err.(*os.PathError); ok && e.Err
== syscall.ENOSPC {
not thrilled about using syscall here. a more portable example would be better.
suggestions welcome, but this will do for now.

[bradfitz, 2012-03-20 23:45:13]

Yeah, the example is pretty lame:  why would opening a file for read
(os.Open) return ENOSPC anyway?

I can't think of a better example that uses PathError.  Pretty much
everything within PathError is a syscall error, and using os.IsNotExist
doesn't show off unpacking a PathError.

Let me at least change that to a Create instead of an Open?


On Tue, Mar 20, 2012 at 4:35 PM, <r@golang.org> wrote:

> LGTM but maybe there's a better solution
>
>
>
http://codereview.appspot.com/**5866046/diff/5001/doc/**effective_go.html<htt...
> File doc/effective_go.html (right):
>
> http://codereview.appspot.com/**5866046/diff/5001/doc/**
>
effective_go.html#newcode2718<http://codereview.appspot.com/5866046/diff/5001/doc/effective_go.html#newcode2718>
> doc/effective_go.html:2718: if e, ok := err.(*os.PathError); ok
>
> &amp;&amp; e.Err == syscall.ENOSPC {
> not thrilled about using syscall here. a more portable example would be
> better. suggestions welcome, but this will do for now.
>
>
http://codereview.appspot.com/**5866046/<http://codereview.appspot.com/5866046/>
>

[bradfitz, 2012-03-20 23:45:39]

Actually I'll wait for further thoughts on this for a bit.

Opinions welcome.


On Tue, Mar 20, 2012 at 4:45 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> Yeah, the example is pretty lame:  why would opening a file for read
> (os.Open) return ENOSPC anyway?
>
> I can't think of a better example that uses PathError.  Pretty much
> everything within PathError is a syscall error, and using os.IsNotExist
> doesn't show off unpacking a PathError.
>
> Let me at least change that to a Create instead of an Open?
>
>
> On Tue, Mar 20, 2012 at 4:35 PM, <r@golang.org> wrote:
>
>> LGTM but maybe there's a better solution
>>
>>
>>
http://codereview.appspot.com/**5866046/diff/5001/doc/**effective_go.html<htt...
>> File doc/effective_go.html (right):
>>
>> http://codereview.appspot.com/**5866046/diff/5001/doc/**
>>
effective_go.html#newcode2718<http://codereview.appspot.com/5866046/diff/5001/doc/effective_go.html#newcode2718>
>> doc/effective_go.html:2718: if e, ok := err.(*os.PathError); ok
>>
>> &amp;&amp; e.Err == syscall.ENOSPC {
>> not thrilled about using syscall here. a more portable example would be
>> better. suggestions welcome, but this will do for now.
>>
>>
http://codereview.appspot.com/**5866046/<http://codereview.appspot.com/5866046/>
>>
>
>

[r2, 2012-03-20 23:46:28]

On Mar 21, 2012, at 10:45 AM, Brad Fitzpatrick wrote:

> Yeah, the example is pretty lame:  why would opening a file for read (os.Open)
return ENOSPC anyway?
> 
> I can't think of a better example that uses PathError.  Pretty much everything
within PathError is a syscall error, and using os.IsNotExist doesn't show off
unpacking a PathError.
> 
> Let me at least change that to a Create instead of an Open?

i tried changing this to a TempFile simulation but it didn't help much.

s/Open/Create/ and LGTM

it makes the point even if the snippet is silly on its own.

-rob

[bradfitz, 2012-03-20 23:50:54]

*** Submitted as http://code.google.com/p/go/source/detail?r=72bdb129534a ***

doc: remove reference to deleted os.ENOSPC

R=golang-dev, gri, r, r
CC=golang-dev
http://codereview.appspot.com/5866046