Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3392)

Issue 58590043: code review 58590043: go.talks: add "Towards Go 1.3" talk (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by adg
Modified:
10 years, 2 months ago
Reviewers:
nathany, r, dvyukov
CC:
dvyukov, r, josharian, ioe, golang-codereviews, golang-dev
Visibility:
Public.

Description

go.talks: add "Towards Go 1.3" talk

Patch Set 1 #

Patch Set 2 : diff -r c8f1acbf8c2e https://code.google.com/p/go.talks #

Patch Set 3 : diff -r c8f1acbf8c2e https://code.google.com/p/go.talks #

Patch Set 4 : diff -r c8f1acbf8c2e https://code.google.com/p/go.talks #

Patch Set 5 : diff -r c8f1acbf8c2e https://code.google.com/p/go.talks #

Patch Set 6 : diff -r c8f1acbf8c2e https://code.google.com/p/go.talks #

Total comments: 2

Patch Set 7 : diff -r c8f1acbf8c2e https://code.google.com/p/go.talks #

Total comments: 30

Patch Set 8 : diff -r c8f1acbf8c2e https://code.google.com/p/go.talks #

Total comments: 3

Patch Set 9 : diff -r 8ba8178daf61 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1591 lines, -0 lines) Patch
A 2014/go1.3.slide View 1 2 3 4 5 6 7 8 1 chunk +323 lines, -0 lines 0 comments Download
A 2014/go1.3/json.png View 1 2 Binary file 0 comments Download
A 2014/go1.3/liblink.graffle View 1 2 3 1 chunk +1268 lines, -0 lines 0 comments Download
A 2014/go1.3/liblink1.png View 1 Binary file 0 comments Download
A 2014/go1.3/liblink2.png View 1 Binary file 0 comments Download

Messages

Total messages: 13
adg
Hello dvyukov, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
10 years, 2 months ago (2014-02-05 09:52:54 UTC) #1
dvyukov
https://codereview.appspot.com/58590043/diff/100001/2014/go1.3.slide File 2014/go1.3.slide (right): https://codereview.appspot.com/58590043/diff/100001/2014/go1.3.slide#newcode82 2014/go1.3.slide:82: - make contended synchronous channel operations faster (use buffering!) ...
10 years, 2 months ago (2014-02-05 10:37:35 UTC) #2
dvyukov
LGTM but wait for r
10 years, 2 months ago (2014-02-05 10:37:47 UTC) #3
adg
https://codereview.appspot.com/58590043/diff/100001/2014/go1.3.slide File 2014/go1.3.slide (right): https://codereview.appspot.com/58590043/diff/100001/2014/go1.3.slide#newcode82 2014/go1.3.slide:82: - make contended synchronous channel operations faster (use buffering!) ...
10 years, 2 months ago (2014-02-05 12:42:33 UTC) #4
josharian
Nice summary. https://codereview.appspot.com/58590043/diff/120001/2014/go1.3.slide File 2014/go1.3.slide (right): https://codereview.appspot.com/58590043/diff/120001/2014/go1.3.slide#newcode53 2014/go1.3.slide:53: - increase page size to 8K (~10% ...
10 years, 2 months ago (2014-02-05 18:25:32 UTC) #5
r
https://codereview.appspot.com/58590043/diff/120001/2014/go1.3.slide File 2014/go1.3.slide (right): https://codereview.appspot.com/58590043/diff/120001/2014/go1.3.slide#newcode16 2014/go1.3.slide:16: (Six months after Go 1.2; released December 1, 2013.) ...
10 years, 2 months ago (2014-02-05 18:55:56 UTC) #6
ioe
added the comment about *global* free list in order to avoid the confusion with e.g. ...
10 years, 2 months ago (2014-02-05 19:29:18 UTC) #7
adg
PTAL https://codereview.appspot.com/58590043/diff/120001/2014/go1.3.slide File 2014/go1.3.slide (right): https://codereview.appspot.com/58590043/diff/120001/2014/go1.3.slide#newcode16 2014/go1.3.slide:16: (Six months after Go 1.2; released December 1, ...
10 years, 2 months ago (2014-02-06 03:30:04 UTC) #8
r
LGTM https://codereview.appspot.com/58590043/diff/140001/2014/go1.3.slide File 2014/go1.3.slide (right): https://codereview.appspot.com/58590043/diff/140001/2014/go1.3.slide#newcode57 2014/go1.3.slide:57: - smarter slice grow (2-20% less cpu) s/cpu/CPU/ ...
10 years, 2 months ago (2014-02-06 03:43:40 UTC) #9
nathany
https://codereview.appspot.com/58590043/diff/140001/2014/go1.3.slide File 2014/go1.3.slide (right): https://codereview.appspot.com/58590043/diff/140001/2014/go1.3.slide#newcode176 2014/go1.3.slide:176: .link http://golang.org/cl/48310043 Just wanted to mention a draft API ...
10 years, 2 months ago (2014-02-06 04:44:14 UTC) #10
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=5c1ef7ac81bc&repo=talks *** go.talks: add "Towards Go 1.3" talk LGTM=dvyukov, r R=dvyukov, r, ...
10 years, 2 months ago (2014-02-06 04:56:48 UTC) #11
adg
On 6 February 2014 05:44, <nj@nathany.com> wrote: > Just wanted to mention a draft API ...
10 years, 2 months ago (2014-02-06 04:56:54 UTC) #12
nathany
10 years, 2 months ago (2014-02-06 05:03:26 UTC) #13
Message was sent while issue was closed.
On 2014/02/06 04:56:54, adg wrote:
> On 6 February 2014 05:44, <mailto:nj@nathany.com> wrote:
> 
> > Just wanted to mention a draft API doc: http://goo.gl/MrYxyA
> >
> > It's still really rough, so I'm not sure if it makes sense to link to
> > yet.
> >
> 
> I ran out of space on the slide.

Not a problem.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b