Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 5858043: code review 5858043: doc: general update of gccgo_install (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by iant
Modified:
13 years ago
Reviewers:
CC:
golang-dev, bradfitz, minux1, r
Visibility:
Public.

Description

doc: general update of gccgo_install Fixes issue 3325.

Patch Set 1 #

Total comments: 8

Patch Set 2 : diff -r 05fd7717dfc0 https://go.googlecode.com/hg/ #

Total comments: 16

Patch Set 3 : diff -r f71a8aea4361 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -118 lines) Patch
M doc/gccgo_install.html View 1 2 16 chunks +217 lines, -118 lines 0 comments Download

Messages

Total messages: 7
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years ago (2012-03-20 18:24:09 UTC) #1
bradfitz
LGTM that's a lot of docs. http://codereview.appspot.com/5858043/diff/1/doc/gccgo_install.html File doc/gccgo_install.html (right): http://codereview.appspot.com/5858043/diff/1/doc/gccgo_install.html#newcode50 doc/gccgo_install.html:50: convenience, a known ...
13 years ago (2012-03-20 18:36:10 UTC) #2
minux1
http://codereview.appspot.com/5858043/diff/1/doc/gccgo_install.html File doc/gccgo_install.html (right): http://codereview.appspot.com/5858043/diff/1/doc/gccgo_install.html#newcode18 doc/gccgo_install.html:18: Note that gccgo is not the 6g compiler; see ...
13 years ago (2012-03-20 18:36:40 UTC) #3
iant
Thanks for the comments. Updated. http://codereview.appspot.com/5858043/diff/1/doc/gccgo_install.html File doc/gccgo_install.html (right): http://codereview.appspot.com/5858043/diff/1/doc/gccgo_install.html#newcode18 doc/gccgo_install.html:18: Note that gccgo is ...
13 years ago (2012-03-20 18:53:29 UTC) #4
r
LGTM this is great please run tidy before submitting http://codereview.appspot.com/5858043/diff/3003/doc/gccgo_install.html File doc/gccgo_install.html (right): http://codereview.appspot.com/5858043/diff/3003/doc/gccgo_install.html#newcode10 doc/gccgo_install.html:10: ...
13 years ago (2012-03-20 20:51:28 UTC) #5
iant
Thanks. Submitting. http://codereview.appspot.com/5858043/diff/3003/doc/gccgo_install.html File doc/gccgo_install.html (right): http://codereview.appspot.com/5858043/diff/3003/doc/gccgo_install.html#newcode10 doc/gccgo_install.html:10: frontend itself is under a BSD-style license, ...
13 years ago (2012-03-20 21:16:13 UTC) #6
iant
13 years ago (2012-03-20 21:16:39 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=ec3f6fe48043 ***

doc: general update of gccgo_install

Fixes issue 3325.

R=golang-dev, bradfitz, minux.ma, r
CC=golang-dev
http://codereview.appspot.com/5858043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b