Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)

Issue 58580043: code review 58580043: cmd/gc: do not consider length zero arrays as comparable. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by remyoudompheng
Modified:
10 years, 1 month ago
Reviewers:
gobot, khr, khr1
CC:
rsc, bradfitz, khr, golang-codereviews
Visibility:
Public.

Description

cmd/gc: do not consider length zero arrays as comparable. Array values are comparable if values of the array element type are comparable. Fixes issue 6526.

Patch Set 1 #

Patch Set 2 : diff -r a177faebc7fc https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a177faebc7fc https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a177faebc7fc https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 4193f3bd6bcc https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/cmd/gc/subr.c View 1 1 chunk +0 lines, -2 lines 0 comments Download
M test/cmp6.go View 1 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 7
remyoudompheng
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 2 months ago (2014-01-30 07:36:12 UTC) #1
remyoudompheng
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 2 months ago (2014-01-30 07:57:17 UTC) #2
bradfitz
R=iant,khr On Thu, Jan 30, 2014 at 8:36 AM, <remyoudompheng@gmail.com> wrote: > Reviewers: rsc, > ...
10 years, 2 months ago (2014-01-30 08:48:44 UTC) #3
khr
On 2014/01/30 08:48:44, bradfitz wrote: > R=iant,khr > > > > On Thu, Jan 30, ...
10 years, 1 month ago (2014-01-30 18:22:28 UTC) #4
remyoudompheng
*** Submitted as https://code.google.com/p/go/source/detail?r=0d73da58cc21 *** cmd/gc: do not consider length zero arrays as comparable. Array ...
10 years, 1 month ago (2014-01-30 23:31:07 UTC) #5
gobot
This CL appears to have broken the freebsd-amd64 builder.
10 years, 1 month ago (2014-01-30 23:35:52 UTC) #6
khr1
10 years, 1 month ago (2014-01-30 23:52:24 UTC) #7
Nope, I believe that crash is issue 7205.



On Thu, Jan 30, 2014 at 3:35 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the freebsd-amd64 builder.
>
> https://codereview.appspot.com/58580043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b