Issue 5857045: code review 5857045: gc: improve error message for composite literals with u...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5857045: code review 5857045: gc: improve error message for composite literals with u...

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by rmmh

Modified:
12 years, 11 months ago

Reviewers:
rsc

CC:
golang-dev, r, rsc

Visibility:
Public.

Description

gc: improve error message for composite literals with unexpected newlines

Patch Set 1 #

Patch Set 2 : diff -r f71a8aea4361 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f71a8aea4361 https://go.googlecode.com/hg/ #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
M	src/cmd/gc/go.errors	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/gc/yerr.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
A	test/syntax/composite.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rmmh

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years ago (2012-03-21 00:41:37 UTC) #1

Looks worthwhile, but not critical. Let's hold off until Go 1 is out. -rob

13 years ago (2012-03-21 02:00:13 UTC) #2

rmmh

Bumping now that Go 1 is out. This change is entirely cosmetic.

12 years, 12 months ago (2012-03-29 03:34:50 UTC) #3

rsc

12 years, 11 months ago (2012-04-02 15:00:58 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=96e7268052c3 ***

gc: improve error message for composite literals with unexpected newlines

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/5857045

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages