Issue 5857043: code review 5857043: crypto/tls: don't select ECC ciphersuites with no mutua...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5857043: code review 5857043: crypto/tls: don't select ECC ciphersuites with no mutua... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 12 months ago by agl1

Modified:
12 years, 11 months ago

Reviewers:

CC:
golang-dev, r, bradfitz

Visibility:
Public.

Description

crypto/tls: don't select ECC ciphersuites with no mutual curve. The existing code that tried to prevent ECC ciphersuites from being selected when there were no mutual curves still left |suite| set. This lead to a panic on a nil pointer when there were no acceptable ciphersuites at all. Thanks to George Kadianakis for pointing it out.

Patch Set 1 #

Patch Set 2 : diff -r 0002f1f792e0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0002f1f792e0 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3b7bb1bf125e https://go.googlecode.com/hg/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	src/pkg/crypto/tls/handshake_server.go	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download
	M	src/pkg/crypto/tls/key_agreement.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 12 months ago (2012-03-20 18:16:46 UTC) #1

agl1

On Wed, Mar 21, 2012 at 11:32 PM, <r@golang.org> wrote: > LGTM but what's your ...

12 years, 11 months ago (2012-03-22 15:27:07 UTC) #3

bradfitz

LGTM too On Thu, Mar 22, 2012 at 8:27 AM, Adam Langley <agl@golang.org> wrote: > ...

12 years, 11 months ago (2012-03-22 15:36:25 UTC) #4

agl1

(p.s. I'll wait for someone to stand up an officially say that it's good to ...

12 years, 11 months ago (2012-03-22 23:50:39 UTC) #5

agl1

12 years, 11 months ago (2012-03-23 14:49:09 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=1b55ed5c1e42 ***

crypto/tls: don't select ECC ciphersuites with no mutual curve.

The existing code that tried to prevent ECC ciphersuites from being
selected when there were no mutual curves still left |suite| set.
This lead to a panic on a nil pointer when there were no acceptable
ciphersuites at all.

Thanks to George Kadianakis for pointing it out.

R=golang-dev, r, bradfitz
CC=golang-dev
http://codereview.appspot.com/5857043

Expand All Messages | Collapse All Messages