Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 5853044: code review 5853044: os: add missing byte to FileMode buffer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 12 months ago by Stefan Nilsson
Modified:
12 years, 11 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

os: add missing byte to FileMode buffer 32 bytes is enough for all FileMode bits.

Patch Set 1 #

Patch Set 2 : diff -r b15d9965bcd8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0a5692d60e01 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r a216dfd16073 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r a216dfd16073 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 9dbdb74ca333 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/os/types.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
Stefan Nilsson
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 12 months ago (2012-03-18 21:30:23 UTC) #1
r
http://codereview.appspot.com/5853044/diff/3001/src/pkg/os/types.go File src/pkg/os/types.go (right): http://codereview.appspot.com/5853044/diff/3001/src/pkg/os/types.go#newcode61 src/pkg/os/types.go:61: const rwx = "rwxrwxrwx" since m is a uint32, ...
12 years, 12 months ago (2012-03-18 23:22:20 UTC) #2
Stefan Nilsson
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 12 months ago (2012-03-19 06:35:42 UTC) #3
r
http://codereview.appspot.com/5853044/diff/4003/src/pkg/os/types.go File src/pkg/os/types.go (right): http://codereview.appspot.com/5853044/diff/4003/src/pkg/os/types.go#newcode61 src/pkg/os/types.go:61: var buf [32]byte Please include the comment I mentioned ...
12 years, 12 months ago (2012-03-19 06:44:13 UTC) #4
Stefan Nilsson
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 12 months ago (2012-03-19 06:47:01 UTC) #5
r
The only thing left is that the CL description is inaccurate now. After the first ...
12 years, 12 months ago (2012-03-19 06:50:35 UTC) #6
Stefan Nilsson
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 11 months ago (2012-03-23 17:08:54 UTC) #7
r
LGTM
12 years, 11 months ago (2012-03-23 21:16:19 UTC) #8
r
12 years, 11 months ago (2012-03-23 21:17:03 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=59f7059d66e9 ***

os: add missing byte to FileMode buffer

32 bytes is enough for all FileMode bits.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5853044

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b