code review 5853044: os: add missing byte to FileMode buffer

os: add missing byte to FileMode buffer

32 bytes is enough for all FileMode bits.

[Stefan Nilsson, 2012-03-18 21:30:23]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-03-18 23:22:20]

http://codereview.appspot.com/5853044/diff/3001/src/pkg/os/types.go
File src/pkg/os/types.go (right):

http://codereview.appspot.com/5853044/diff/3001/src/pkg/os/types.go#newcode61
src/pkg/os/types.go:61: const rwx = "rwxrwxrwx"
since m is a uint32, why not just do
var buf [32]byte // Mode is uint32.

[Stefan Nilsson, 2012-03-19 06:35:42]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2012-03-19 06:44:13]

http://codereview.appspot.com/5853044/diff/4003/src/pkg/os/types.go
File src/pkg/os/types.go (right):

http://codereview.appspot.com/5853044/diff/4003/src/pkg/os/types.go#newcode61
src/pkg/os/types.go:61: var buf [32]byte
Please include the comment I mentioned in my previous mail.

[Stefan Nilsson, 2012-03-19 06:47:01]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2012-03-19 06:50:35]

The only thing left is that the CL description is inaccurate now. 
After the first line, say

Need 32 bits for all FileMode bits.

or something equivalent

[Stefan Nilsson, 2012-03-23 17:08:54]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2012-03-23 21:16:19]

LGTM

[r, 2012-03-23 21:17:03]

*** Submitted as http://code.google.com/p/go/source/detail?r=59f7059d66e9 ***

os: add missing byte to FileMode buffer

32 bytes is enough for all FileMode bits.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5853044

Committer: Rob Pike <r@golang.org>