code review 5848063: doc/effective_go: minor corrections

doc/effective_go: minor corrections

[minux1, 2012-03-21 15:57:44]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[gri, 2012-03-21 16:12:54]

http://codereview.appspot.com/5848063/diff/7001/doc/effective_go.html
File doc/effective_go.html (right):

http://codereview.appspot.com/5848063/diff/7001/doc/effective_go.html#newcode774
doc/effective_go.html:774: The signature of <code>(*File).Write</code> in
package <code>os</code> is:
I would write this as <code>File.Write</code> since methods are bound to the
receiver's base type (which is File, not *File).

[minux1, 2012-03-21 16:17:05]

PTAL.
On 2012/03/21 16:12:54, gri wrote:
http://codereview.appspot.com/5848063/diff/7001/doc/effective_go.html#newcode774
> doc/effective_go.html:774: The signature of <code>(*File).Write</code> in
> package <code>os</code> is:
> I would write this as <code>File.Write</code> since methods are bound to the
> receiver's base type (which is File, not *File).
Done.

[gri, 2012-03-21 16:26:26]

LGTM

Please also fix the sentence below - I missed that one in the first round.
Thanks.

http://codereview.appspot.com/5848063/diff/7002/doc/effective_go.html
File doc/effective_go.html (right):

http://codereview.appspot.com/5848063/diff/7002/doc/effective_go.html#newcode...
doc/effective_go.html:1332: because equality is not defined on it.
s/it/them/

[minux1, 2012-03-21 16:28:11]

PTAL.

I also changed a few "in parallel" to "concurrently", because
I think it is not correct to use "in parallel" as it might not run
in parallel if GOMAXPROCS == 1.

[gri, 2012-03-21 16:33:25]

LGTM

Great, thanks!
- gri

[gri, 2012-03-21 16:34:00]

*** Submitted as http://code.google.com/p/go/source/detail?r=509fce3ba4e1 ***

doc/effective_go: minor corrections

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5848063

Committer: Robert Griesemer <gri@golang.org>

[r, 2012-03-21 20:52:09]

http://codereview.appspot.com/5848063/diff/5004/doc/effective_go.html
File doc/effective_go.html (right):

http://codereview.appspot.com/5848063/diff/5004/doc/effective_go.html#newcode...
doc/effective_go.html:2707: errors and extract details.  For
<code>PathError</code>s
please undo this change. it looks weird.
there is no need to switch fonts mid word.

i don't have a working setup at the moment so i can't do this myself.