Issue 5848062: code review 5848062: gc: fix struct and array comparisons for new bool rules

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5848062: code review 5848062: gc: fix struct and array comparisons for new bool rules (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by ality

Modified:
13 years ago

Reviewers:

CC:
rsc, lvd1, golang-dev

Visibility:
Public.

Description

gc: fix struct and array comparisons for new bool rules The two optimizations for small structs and arrays were missing the implicit cast from ideal bool. Fixes issue 3351.

Patch Set 1 #

Patch Set 2 : diff -r a216dfd16073 https://code.google.com/p/go/ #

Patch Set 3 : diff -r a216dfd16073 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 0002f1f792e0 https://code.google.com/p/go/ #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -0 lines)			Patch
	M	src/cmd/gc/walk.c	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
	A	test/fixedbugs/bug427.go	View	1	1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years ago (2012-03-19 10:34:23 UTC) #1

lvd1

LGTM (rsc is on holiday, so i'll take this) thanks for finding and fixing.

13 years ago (2012-03-19 15:29:13 UTC) #2

ality

13 years ago (2012-03-19 22:57:34 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=8824dae9afdc ***

gc: fix struct and array comparisons for new bool rules

The two optimizations for small structs and arrays
were missing the implicit cast from ideal bool.

Fixes issue 3351.

R=rsc, lvd
CC=golang-dev
http://codereview.appspot.com/5848062

Expand All Messages | Collapse All Messages