Issue 58480045: code review 58480045: cmd/go: skip $ORIGIN test on darwin systems

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 58480045: code review 58480045: cmd/go: skip $ORIGIN test on darwin systems (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by dave

Modified:
10 years, 2 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

cmd/go: skip $ORIGIN test on darwin systems Fixes issue 7293. Update issue 7261 The bsd ld(1) does not understand $ORIGIN and has restrictions on using -rpath when using clang(1), the default compiler on darwin.

Patch Set 1 #

Patch Set 2 : diff -r b1f7a2f34d33 https://code.google.com/p/go #

Patch Set 3 : diff -r b1f7a2f34d33 https://code.google.com/p/go #

Patch Set 4 : diff -r b1f7a2f34d33 https://code.google.com/p/go #

Patch Set 5 : diff -r b1f7a2f34d33 https://code.google.com/p/go #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
		src/cmd/go/test.bash	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 2 months ago (2014-02-10 00:58:47 UTC) #1

dave_cheney.net

10 years, 2 months ago (2014-02-10 02:35:56 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=028678d23c22 ***

cmd/go: skip $ORIGIN test on darwin systems

Fixes issue 7293.

Update issue 7261

The bsd ld(1) does not understand $ORIGIN and has restrictions on using -rpath
when using clang(1), the default compiler on darwin.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/58480045

Expand All Messages | Collapse All Messages