Issue 5841050: code review 5841050: doc: update format for "C? Go? Cgo!" article

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5841050: code review 5841050: doc: update format for "C? Go? Cgo!" article (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by minux1

Modified:
13 years ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

doc: update format for "C? Go? Cgo!" article

Patch Set 2 : diff -r a303acb0a5f2 https://code.google.com/p/go/ #

Patch Set 3 : diff -r a303acb0a5f2 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r a216dfd16073 https://code.google.com/p/go/ #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -31 lines)			Patch
	M	doc/articles/c_go_cgo.html	View	1 2 3	5 chunks	+30 lines, -29 lines	0 comments	Download
	M	doc/progs/cgo1.go	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years ago (2012-03-16 16:08:58 UTC) #1

adg

LGTM with one change http://codereview.appspot.com/5841050/diff/3001/doc/articles/c_go_cgo.html File doc/articles/c_go_cgo.html (right): http://codereview.appspot.com/5841050/diff/3001/doc/articles/c_go_cgo.html#newcode38 doc/articles/c_go_cgo.html:38: The <code>Random</code> function calls the ...

13 years ago (2012-03-18 22:37:51 UTC) #2

minux1

13 years ago (2012-03-19 14:54:22 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c47b0caa500e ***

doc: update format for "C? Go? Cgo!" article

R=adg
CC=golang-dev
http://codereview.appspot.com/5841050

Expand All Messages | Collapse All Messages