Issue 5837047: code review 5837047: os: do not assume syscall.Write will write everything

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5837047: code review 5837047: os: do not assume syscall.Write will write everything (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by rsc

Modified:
10 years, 5 months ago

Reviewers:
gri, Frank

CC:
golang-dev, remyoudompheng, gri

Visibility:
Public.

Description

os: do not assume syscall.Write will write everything Fixes issue 3323.

Patch Set 1 #

Patch Set 2 : diff -r 4e75871bad16 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f556158ba811 https://go.googlecode.com/hg/ #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	src/pkg/os/file_unix.go	View	1	1 chunk	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years ago (2012-03-15 18:51:38 UTC) #1

remyoudompheng

Should it be explicitly documented that the behaviour is that an error is returned iff ...

13 years ago (2012-03-15 18:58:19 UTC) #2

rsc

On Thu, Mar 15, 2012 at 14:58, <remyoudompheng@gmail.com> wrote: > Should it be explicitly documented ...

13 years ago (2012-03-15 19:00:02 UTC) #3

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=703ef1d5f5e7 *** os: do not assume syscall.Write will write everything Fixes issue ...

13 years ago (2012-03-15 19:10:22 UTC) #5

Frank

10 years, 5 months ago (2014-10-13 15:50:55 UTC) #6

Message was sent while issue was closed.

On 2012/03/15 19:10:22, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=703ef1d5f5e7 ***
> 
> os: do not assume syscall.Write will write everything
> 
> Fixes issue 3323.
> 
> R=golang-dev, remyoudompheng, gri
> CC=golang-dev
> http://codereview.appspot.com/5837047

Hello,
not sure whether this is the right place to note this, but it seems that this
correction only fixes that case for the Unix write.
The Windows write (http://golang.org/src/pkg/os/file_windows.go) does still not
loop and will hence return an 'ErrShortWrite'
just after the first short write.
Thanks for taking notice, Frank

Expand All Messages | Collapse All Messages