Issue 5835043: code review 5835043: cmd/godoc: add toys, tour button to playground

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5835043: code review 5835043: cmd/godoc: add toys, tour button to playground (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by adg

Modified:
13 years ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/godoc: add toys, tour button to playground Fixes issue 3241.

Patch Set 2 : diff -r 59b7d79b616f https://go.googlecode.com/hg #

Total comments: 1

Patch Set 3 : diff -r 59b7d79b616f https://go.googlecode.com/hg #

Patch Set 4 : diff -r f04024741479 https://go.googlecode.com/hg #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+476 lines, -44 lines)			Patch
A	doc/play/fib.go	View		1 chunk	+17 lines, -0 lines	0 comments	Download
A	doc/play/hello.go	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	doc/play/peano.go	View		1 chunk	+88 lines, -0 lines	0 comments	Download
A	doc/play/pi.go	View		1 chunk	+34 lines, -0 lines	0 comments	Download
M	doc/play/playground.js	View		3 chunks	+55 lines, -34 lines	0 comments	Download
A	doc/play/sieve.go	View		1 chunk	+34 lines, -0 lines	0 comments	Download
A	doc/play/solitaire.go	View	1	1 chunk	+117 lines, -0 lines	0 comments	Download
A	doc/play/tree.go	View	1 2	1 chunk	+100 lines, -0 lines	0 comments	Download
M	doc/root.html	View		2 chunks	+16 lines, -3 lines	0 comments	Download
M	doc/style.css	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/cmd/godoc/godoc.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

13 years ago (2012-03-15 06:18:42 UTC) #1

http://codereview.appspot.com/5835043/diff/13/doc/play/tree.go File doc/play/tree.go (right): http://codereview.appspot.com/5835043/diff/13/doc/play/tree.go#newcode2 doc/play/tree.go:2: // but have the same contents. For example: this ...

13 years ago (2012-03-15 06:23:36 UTC) #2

adg

Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years ago (2012-03-15 06:31:24 UTC) #3

adg

13 years ago (2012-03-15 06:44:56 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=d50f81a8b1d0 ***

cmd/godoc: add toys, tour button to playground

Fixes issue 3241.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5835043

Expand All Messages | Collapse All Messages