Issue 5825047: code review 5825047: go.image/bmp: fix warnings from go vet

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5825047: code review 5825047: go.image/bmp: fix warnings from go vet (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bsiegert

Modified:
12 years, 1 month ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

go.image/bmp: fix warnings from go vet reader.go:138:10: image.Config struct literal uses untagged fields reader.go:144:10: image.Config struct literal uses untagged fields

Patch Set 1 #

Patch Set 2 : diff -r 2bf0db14a16d https://code.google.com/p/go.image #

Patch Set 3 : diff -r 2bf0db14a16d https://code.google.com/p/go.image #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	bmp/reader.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsiegert

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.image

12 years, 2 months ago (2012-03-14 11:37:09 UTC) #1

nigeltao

*** Submitted as http://code.google.com/p/go/source/detail?r=2f33dee36e73&repo=image *** go.image/bmp: fix warnings from go vet reader.go:138:10: image.Config struct literal ...

12 years, 2 months ago (2012-03-14 22:46:11 UTC) #3

*** Abandoned ***

Expand All Messages | Collapse All Messages