Issue 582043: code review 582043: http: change RawPath to mean raw path, not raw everythi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 582043: code review 582043: http: change RawPath to mean raw path, not raw everythi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
15 years ago

Reviewers:

CC:
r, petar-m, ukai, golang-dev, madari

Visibility:
Public.

Description

http: change RawPath to mean raw path, not raw everything-after-scheme. The new meaning is more useful for both websocket and http.

Patch Set 1 #

Patch Set 2 : code review 582043: http: change RawPath to mean raw path, not raw everythi... #

Patch Set 3 : code review 582043: http: change RawPath to mean raw path, not raw everythi... #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -70 lines)			Patch
M	src/pkg/http/readrequest_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/http/requestwrite_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/http/url.go	View		4 chunks	+16 lines, -7 lines	0 comments	Download
M	src/pkg/http/url_test.go	View	1	13 chunks	+91 lines, -61 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com, madari, petar-m, ukai), I'd like you to review this change.

15 years ago (2010-03-16 20:56:05 UTC) #1

rsc

15 years ago (2010-03-17 01:44:58 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=050859c65347 ***

http: change RawPath to mean raw path, not raw everything-after-scheme.

The new meaning is more useful for both websocket and http.

R=r, petar-m, ukai
CC=golang-dev, madari
http://codereview.appspot.com/582043

Expand All Messages | Collapse All Messages