Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(161)

Issue 5820044: code review 5820044: go/printer, gofmt: fix multi-line logic (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by gri
Modified:
13 years ago
Reviewers:
rsc
CC:
dsymonds, golang-dev
Visibility:
Public.

Description

go/printer, gofmt: fix multi-line logic A node spans multiple lines if the line difference between start and end point is > 0 (rather than > 1). Fixes some odd cases introduced by CL 5706055; pointed out by dsymonds. Added corresponding test case. The other change in the .golden file reverts to the status before the CL mentioned above and is correct. gofmt -w src misc changes godoc.go back to where it was before the CL mentioned above. Fixes issue 3304.

Patch Set 1 #

Patch Set 2 : diff -r 142d5d35e4c2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 142d5d35e4c2 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 142d5d35e4c2 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M src/cmd/godoc/godoc.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/printer/nodes.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/printer/testdata/declarations.golden View 1 2 chunks +13 lines, -2 lines 0 comments Download
M src/pkg/go/printer/testdata/declarations.input View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4
gri
Hello dsymonds@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years ago (2012-03-13 23:08:19 UTC) #1
dsymonds
LGTM
13 years ago (2012-03-13 23:12:41 UTC) #2
gri
*** Submitted as http://code.google.com/p/go/source/detail?r=d40449c628db *** go/printer, gofmt: fix multi-line logic A node spans multiple lines ...
13 years ago (2012-03-13 23:16:02 UTC) #3
rsc
13 years ago (2012-03-14 16:08:52 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b