code review 5815044: doc: add Go Concurrency Patterns: Timing out, moving on...

doc: add Go Concurrency Patterns: Timing out, moving on article

Originally published on The Go Programming Language Blog, September 23, 2010.

http://blog.golang.org/2010/09/go-concurrency-patterns-timing-out-and.html

Update issue 2547.

[fss, 2012-03-13 22:21:50]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[adg, 2012-03-13 23:18:26]

http://codereview.appspot.com/5815044/diff/10/doc/articles/go_concurrency_pat...
File doc/articles/go_concurrency_patterns_timing_out_moving_on.html (right):

http://codereview.appspot.com/5815044/diff/10/doc/articles/go_concurrency_pat...
doc/articles/go_concurrency_patterns_timing_out_moving_on.html:32: </p>
<p>
(In this example we used <code>time.Sleep</code> to demonstrate the mechanics of
goroutines and channels. In real programs you should use <code><a
href="/pkg/time/#After">time.After</a></code>, a function that returns a channel
and sends on that channel after the specified duration.)
</p>

[adg, 2012-03-13 23:20:54]

Also add this doc to the Makefile, as with this CL

http://codereview.appspot.com/5755057/diff/11001/doc/Makefile

[fss, 2012-03-14 00:44:11]

Added c_go_cgo.html and go_concurrency_patterns_timing_out_moving_on.html to the
Makefile.

I'm wondering if the Makefile is really ok. These lines:

%.rawhtml: %.html
	godoc -url /doc/$* >$@

should be like this:

%.rawhtml: %.html
	godoc -url /doc/$*.html >$@

right? If so, I can include this change in the CL.

https://codereview.appspot.com/5815044/diff/10/doc/articles/go_concurrency_pa...
File doc/articles/go_concurrency_patterns_timing_out_moving_on.html (right):

https://codereview.appspot.com/5815044/diff/10/doc/articles/go_concurrency_pa...
doc/articles/go_concurrency_patterns_timing_out_moving_on.html:32: </p>
On 2012/03/13 23:18:26, adg wrote:
> <p>
> (In this example we used <code>time.Sleep</code> to demonstrate the mechanics
of
> goroutines and channels. In real programs you&nbsp;should use <code><a
> href="/pkg/time/#After">time.After</a></code>, a function that returns a
channel
> and sends on that channel after the specified duration.)
> </p>

Done.

[fss, 2012-03-14 00:49:38]

On 2012/03/14 00:44:11, fsouza wrote:
> Added c_go_cgo.html and go_concurrency_patterns_timing_out_moving_on.html to
the
> Makefile.
> 
> I'm wondering if the Makefile is really ok. These lines:
> 
> %.rawhtml: %.html
> 	godoc -url /doc/$* >$@
> 
> should be like this:
> 
> %.rawhtml: %.html
> 	godoc -url /doc/$*.html >$@
> 
> right? If so, I can include this change in the CL.

nevermind, I had not run hg sync ;)

[adg, 2012-03-14 02:02:56]

LGTM

[adg, 2012-03-14 02:03:19]

*** Submitted as http://code.google.com/p/go/source/detail?r=9c73c9b73258 ***

doc: add Go Concurrency Patterns: Timing out, moving on article

Originally published on The Go Programming Language Blog, September 23, 2010.

http://blog.golang.org/2010/09/go-concurrency-patterns-timing-out-and.html

Update issue 2547.

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5815044

Committer: Andrew Gerrand <adg@golang.org>