Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2790)

Issue 5797068: code review 5797068: runtime: print error on receipt of signal on non-Go thread (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by rsc
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

runtime: print error on receipt of signal on non-Go thread It's the best we can do before Go 1. For issue 3250; not a fix but at least less mysterious.

Patch Set 1 #

Patch Set 2 : diff -r 2594f4a8314e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2594f4a8314e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f24eec3fea75 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -9 lines) Patch
M src/pkg/runtime/sys_darwin_386.s View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/pkg/runtime/sys_darwin_amd64.s View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/pkg/runtime/sys_freebsd_386.s View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/pkg/runtime/sys_freebsd_amd64.s View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/pkg/runtime/sys_linux_386.s View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/pkg/runtime/sys_linux_amd64.s View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/pkg/runtime/sys_netbsd_386.s View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/pkg/runtime/sys_netbsd_amd64.s View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/pkg/runtime/sys_openbsd_386.s View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/pkg/runtime/sys_openbsd_amd64.s View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/pkg/runtime/sys_windows_386.s View 1 2 chunks +28 lines, -0 lines 0 comments Download
M src/pkg/runtime/sys_windows_amd64.s View 1 2 chunks +30 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_darwin.c View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_freebsd.c View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_linux.c View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_netbsd.c View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_openbsd.c View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_plan9.c View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_windows.c View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 1 month ago (2012-03-12 18:58:27 UTC) #1
bradfitz
LGTM On Mon, Mar 12, 2012 at 11:58 AM, <rsc@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
12 years, 1 month ago (2012-03-12 19:54:15 UTC) #2
rsc
12 years, 1 month ago (2012-03-12 19:55:21 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=0f4f12f8e239 ***

runtime: print error on receipt of signal on non-Go thread

It's the best we can do before Go 1.

For issue 3250; not a fix but at least less mysterious.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5797068
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b