Issue 5795067: code review 5795067: doc/progs: skip cgo1 and cgo2 on freebsd

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5795067: code review 5795067: doc/progs: skip cgo1 and cgo2 on freebsd (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by adg

Modified:
13 years ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

doc/progs: skip cgo1 and cgo2 on freebsd FreeBSD's srandom has a different signature to darwin/linux.

Patch Set 2 : diff -r 426b1101b166 https://go.googlecode.com/hg #

Total comments: 1

Patch Set 3 : diff -r 426b1101b166 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 97d498d864a3 https://code.google.com/p/go #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	doc/progs/run	View	1 2	2 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

13 years ago (2012-03-12 23:06:35 UTC) #1

adg

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years ago (2012-03-12 23:31:43 UTC) #2

dsymonds

LGTM http://codereview.appspot.com/5795067/diff/2001/doc/progs/run File doc/progs/run (right): http://codereview.appspot.com/5795067/diff/2001/doc/progs/run#newcode40 doc/progs/run:40: if [[ "$goos" == "freebsd" ]]; then You ...

13 years ago (2012-03-13 00:06:23 UTC) #3

adg

13 years ago (2012-03-13 00:55:22 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=e9413993dcbe ***

doc/progs: skip cgo1 and cgo2 on freebsd

FreeBSD's srandom has a different signature to darwin/linux.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5795067

Expand All Messages | Collapse All Messages