Issue 5786047: code review 5786047: cmd/cgo: silence const warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5786047: code review 5786047: cmd/cgo: silence const warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by rsc

Modified:
12 years, 1 month ago

Reviewers:

CC:
golang-dev, dsymonds, r

Visibility:
Public.

Description

cmd/cgo: silence const warnings Fixes issue 3152.

Patch Set 1 #

Patch Set 2 : diff -r da7ac33e249e https://code.google.com/p/go/ #

Patch Set 3 : diff -r da7ac33e249e https://code.google.com/p/go/ #

Patch Set 4 : diff -r da7ac33e249e https://code.google.com/p/go/ #

Patch Set 5 : diff -r c58180d542cc https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	src/cmd/cgo/out.go	View	1 2 3	1 chunk	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2012-03-08 03:16:15 UTC) #1

dsymonds

"Howver" => "However". (No idea on correctness, of the patch.)

12 years, 1 month ago (2012-03-08 03:21:04 UTC) #2

rsc

12 years, 1 month ago (2012-03-08 03:40:45 UTC) #4

*** Submitted as 83e8f7f6d029 ***

cmd/cgo: silence const warnings

Fixes issue 3152.

R=golang-dev, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/5786047

Expand All Messages | Collapse All Messages