code review 5784083: misc/dist: don't ship cmd/cov or cmd/prof

misc/dist: don't ship cmd/cov or cmd/prof

Fixes issue 3317

[bradfitz, 2012-03-14 23:35:15]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-03-14 23:36:05]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-03-14 23:36:47]

Whoops, the initial email didn't have the cmd/dist/build.c change.  Full
diff is:

$ hg diff
diff -r fd6a99a55adc misc/dist/bindist.go
--- a/misc/dist/bindist.go      Thu Mar 15 09:15:16 2012 +1100
+++ b/misc/dist/bindist.go      Wed Mar 14 16:36:18 2012 -0700
@@ -43,6 +43,8 @@
 )

 var preBuildCleanFiles = []string{
+       "src/cmd/cov",
+       "src/cmd/prof",
        "src/pkg/exp",
        "src/pkg/old",
 }
diff -r fd6a99a55adc src/cmd/dist/build.c
--- a/src/cmd/dist/build.c      Thu Mar 15 09:15:16 2012 +1100
+++ b/src/cmd/dist/build.c      Wed Mar 14 16:36:18 2012 -0700
@@ -1214,6 +1214,8 @@
        vinit(&dir);

        for(i=0; i<nelem(cleantab); i++) {
+               if((streq(cleantab[i], "cmd/cov") || streq(cleantab[i],
"cmd/prof")) && !isdir(cleantab[i]))
+                       continue;
                bpathf(&path, "%s/src/%s", goroot, cleantab[i]);
                xreaddir(&dir, bstr(&path));
                // Remove generated files.


On Wed, Mar 14, 2012 at 4:36 PM, <bradfitz@golang.org> wrote:

> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**5784083/<http://codereview.appspot.com/5784083/>
>

[dsymonds, 2012-03-14 23:55:56]

LGTM

[bradfitz, 2012-03-15 22:22:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=ae443f313c8f ***

misc/dist: don't ship cmd/cov or cmd/prof

Fixes issue 3317

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5784083