code review 5783090: misc/dist: trim space from version string

misc/dist: trim space from version string

This prevents us from writing filenames like "weekly.2012-03-12\n.foo.bar.tar.gz".

[adg, 2012-03-13 04:29:59]

Hello bradfitz (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2012-03-13 04:30:38]

LGTM

On Mon, Mar 12, 2012 at 9:29 PM, <adg@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> misc/dist: trim space from version string
>
> This prevents us from writing filenames like
> "weekly.2012-03-12\n.foo.bar.**tar.gz".
>
> Please review this at
http://codereview.appspot.com/**5783090/<http://codereview.appspot.com/5783090/>
>
> Affected files:
>  M misc/dist/bindist.go
>
>
> Index: misc/dist/bindist.go
> ==============================**==============================**=======
> --- a/misc/dist/bindist.go
> +++ b/misc/dist/bindist.go
> @@ -154,6 +154,7 @@
>        if err != nil {
>                return err
>        }
> +       fullVersion = bytes.TrimSpace(fullVersion)
>        v := bytes.SplitN(fullVersion, []byte(" "), 2)
>        version = string(v[0])
>
>
>
>

[adg, 2012-03-13 04:31:43]

*** Submitted as http://code.google.com/p/go/source/detail?r=e82e7fd9b777 ***

misc/dist: trim space from version string

This prevents us from writing filenames like
"weekly.2012-03-12\n.foo.bar.tar.gz".

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/5783090