code review 5783077: weekly.2012-03-12

weekly.2012-03-12

[adg, 2012-03-12 06:19:46]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[nigeltao, 2012-03-12 06:44:47]

LGTM.

http://codereview.appspot.com/5783077/diff/1/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5783077/diff/1/doc/devel/weekly.html#newcode65
doc/devel/weekly.html:65: * deps: allow crypto/x509 cgo and io/ioutil,
?

[adg, 2012-03-12 08:48:04]

PTAL

http://codereview.appspot.com/5783077/diff/1/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5783077/diff/1/doc/devel/weekly.html#newcode65
doc/devel/weekly.html:65: * deps: allow crypto/x509 cgo and io/ioutil,
On 2012/03/12 06:44:47, nigeltao wrote:
> ?

Ah probably worth leaving this out.

[nigeltao, 2012-03-12 11:55:22]

LGTM.

[bradfitz, 2012-03-12 11:55:49]

http://codereview.appspot.com/5783077/diff/4/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5783077/diff/4/doc/devel/weekly.html#newcode64
doc/devel/weekly.html:64: * database/sql{,driver}: add ErrBadConn.
{,/driver}

http://codereview.appspot.com/5783077/diff/4/doc/devel/weekly.html#newcode108
doc/devel/weekly.html:108: do not use reflect for DNS messages (thanks Rémy
Oudompheng),
also, new line: 
   remove dependence on bytes, fmt, strconv

http://codereview.appspot.com/5783077/diff/4/doc/devel/weekly.html#newcode138
doc/devel/weekly.html:138: * unicode/utf16: delete dependence on package
unicode.
s/delete/remove/ for consistency with following line

[adg, 2012-03-12 22:11:16]

http://codereview.appspot.com/5783077/diff/4/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5783077/diff/4/doc/devel/weekly.html#newcode64
doc/devel/weekly.html:64: * database/sql{,driver}: add ErrBadConn.
On 2012/03/12 11:55:49, bradfitz wrote:
> {,/driver}

Done.

http://codereview.appspot.com/5783077/diff/4/doc/devel/weekly.html#newcode108
doc/devel/weekly.html:108: do not use reflect for DNS messages (thanks Rémy
Oudompheng),
On 2012/03/12 11:55:49, bradfitz wrote:
> also, new line: 
>    remove dependence on bytes, fmt, strconv

Done.

http://codereview.appspot.com/5783077/diff/4/doc/devel/weekly.html#newcode138
doc/devel/weekly.html:138: * unicode/utf16: delete dependence on package
unicode.
On 2012/03/12 11:55:49, bradfitz wrote:
> s/delete/remove/ for consistency with following line

Done.

[adg, 2012-03-13 04:09:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=d58f8f9c5a54 ***

weekly.2012-03-12

R=golang-dev, nigeltao, bradfitz
CC=golang-dev
http://codereview.appspot.com/5783077