Issue 5781058: code review 5781058: all: gofmt -w -s src misc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5781058: code review 5781058: all: gofmt -w -s src misc (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by gri

Modified:
13 years ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Patch Set 2 : diff -r 7a8c58d0b7b8 https://code.google.com/p/go #

Patch Set 3 : diff -r 7a8c58d0b7b8 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 7a8c58d0b7b8 https://code.google.com/p/go #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -37 lines)			Patch
M	misc/cgo/test/backdoor/backdoor.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	misc/dashboard/app/build/init.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	misc/dashboard/app/build/test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/crypto/tls/handshake_server_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/database/sql/sql_test.go	View	1	1 chunk	+24 lines, -24 lines	0 comments	Download
M	src/pkg/encoding/gob/encoder_test.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/exp/norm/maketables.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/net/http/client_test.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/path/filepath/path_test.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

13 years ago (2012-03-08 18:35:22 UTC) #1

rsc

LGTM except time_test.go http://codereview.appspot.com/5781058/diff/2011/src/pkg/time/time_test.go File src/pkg/time/time_test.go (right): http://codereview.appspot.com/5781058/diff/2011/src/pkg/time/time_test.go#newcode743 src/pkg/time/time_test.go:743: {}, // nil location I'd be ...

13 years ago (2012-03-08 18:37:23 UTC) #2

gri

13 years ago (2012-03-08 18:48:54 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=66caae9a7ddb ***

all: gofmt -w -s src misc

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5781058

Expand All Messages | Collapse All Messages