code review 5768044: cmd/go: fix go test -compiler

cmd/go: fix go test -compiler

The compiler must be changed with the Set method
so that the buildToolchain gets updated too.

Fixes issue 3231.

[rsc, 2012-03-07 17:03:06]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-03-07 17:04:22]

LGTM

On Wed, Mar 7, 2012 at 9:03 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/go: fix go test -compiler
>
> The compiler must be changed with the Set method
> so that the buildToolchain gets updated too.
>
> Fixes issue 3231.
>
> Please review this at
http://codereview.appspot.com/**5768044/<http://codereview.appspot.com/5768044/>
>
> Affected files:
>  M src/cmd/go/testflag.go
>
>
> Index: src/cmd/go/testflag.go
> ==============================**==============================**=======
> --- a/src/cmd/go/testflag.go
> +++ b/src/cmd/go/testflag.go
> @@ -142,7 +142,7 @@
>                case "tags":
>                        buildContext.BuildTags = strings.Fields(value)
>                case "compiler":
> -                       buildContext.Compiler = value
> +                       buildCompiler.Set(value)
>                case "file":
>                        testFiles = append(testFiles, value)
>                case "bench":
>
>
>

[rsc, 2012-03-07 17:09:45]

*** Submitted as http://code.google.com/p/go/source/detail?r=c4130e7ab676 ***

cmd/go: fix go test -compiler

The compiler must be changed with the Set method
so that the buildToolchain gets updated too.

Fixes issue 3231.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5768044