Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 5764044: code review 5764044: doc: update Effective Go init section (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by rsc
Modified:
13 years ago
Reviewers:
ugorji
CC:
golang-dev, gri
Visibility:
Public.

Description

doc: update Effective Go init section Goroutines are no longer excluded from init. Fixes issue 3232.

Patch Set 1 #

Patch Set 2 : diff -r 46f732bd0956 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 4ba5998e2c63 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M doc/effective_go.html View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
13 years ago (2012-03-07 15:14:17 UTC) #1
gri
LGTM - gri On Wed, Mar 7, 2012 at 7:14 AM, <rsc@golang.org> wrote: > Reviewers: ...
13 years ago (2012-03-07 16:37:08 UTC) #2
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=5f2c911ed43a *** doc: update Effective Go init section Goroutines are no longer ...
13 years ago (2012-03-07 16:38:42 UTC) #3
ugorji
Don't we also have to update the effective_go.tmpl document? ie shouldn't the CL include both ...
13 years ago (2012-03-07 16:50:48 UTC) #4
rsc
13 years ago (2012-03-07 16:57:35 UTC) #5
Thank you.

Can we please move the tmpl stuff into godoc?
It seems silly to be maintaining parallel files
when godoc is already using the template package
and can run this itself while serving.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b