Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(364)

Issue 5755051: code review 5755051: doc: fix typos in laws_of_reflection article. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by proppy
Modified:
13 years ago
Reviewers:
CC:
golang-dev, minux1, r, r2, adg
Visibility:
Public.

Description

doc: fix typos in laws_of_reflection article, add copyright notice. Update issue 2547.

Patch Set 1 #

Patch Set 2 : diff -r c1f5756f94b0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c1f5756f94b0 https://go.googlecode.com/hg/ #

Total comments: 5

Patch Set 4 : diff -r c1f5756f94b0 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -18 lines) Patch
M doc/articles/laws_of_reflection.html View 1 2 3 8 chunks +8 lines, -11 lines 0 comments Download
M doc/articles/laws_of_reflection.tmpl View 1 2 3 7 chunks +7 lines, -7 lines 0 comments Download
M doc/progs/interface.go View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M doc/progs/interface2.go View 1 2 3 5 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11
proppy
Hello golang-dev@googlegroups.com (cc: adg@golang.org, golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years ago (2012-03-06 12:50:02 UTC) #1
minux1
http://codereview.appspot.com/5755051/diff/5/doc/articles/laws_of_reflection.tmpl File doc/articles/laws_of_reflection.tmpl (right): http://codereview.appspot.com/5755051/diff/5/doc/articles/laws_of_reflection.tmpl#newcode187 doc/articles/laws_of_reflection.tmpl:187: <a href="http://golang.org/pkg/reflect/#Type">Type</a> and The host port of the URL ...
13 years ago (2012-03-06 13:15:13 UTC) #2
r
http://codereview.appspot.com/5755051/diff/5/doc/articles/laws_of_reflection.html File doc/articles/laws_of_reflection.html (right): http://codereview.appspot.com/5755051/diff/5/doc/articles/laws_of_reflection.html#newcode667 doc/articles/laws_of_reflection.html:667: <pre><!--{{code "progs/interface2.go" `/START f8/` `/START/`}} that looks wrong http://codereview.appspot.com/5755051/diff/5/doc/articles/laws_of_reflection.html#newcode679 ...
13 years ago (2012-03-06 20:36:21 UTC) #3
proppy
http://codereview.appspot.com/5755051/diff/5/doc/articles/laws_of_reflection.html File doc/articles/laws_of_reflection.html (right): http://codereview.appspot.com/5755051/diff/5/doc/articles/laws_of_reflection.html#newcode667 doc/articles/laws_of_reflection.html:667: <pre><!--{{code "progs/interface2.go" `/START f8/` `/START/`}} On 2012/03/06 20:36:21, r ...
13 years ago (2012-03-06 20:46:41 UTC) #4
r2
On 07/03/2012, at 7:46 AM, proppy@google.com wrote: > > http://codereview.appspot.com/5755051/diff/5/doc/articles/laws_of_reflection.html > File doc/articles/laws_of_reflection.html (right): > ...
13 years ago (2012-03-06 20:47:45 UTC) #5
proppy
On 2012/03/06 20:47:45, r2 wrote: > On 07/03/2012, at 7:46 AM, mailto:proppy@google.com wrote: > > ...
13 years ago (2012-03-06 21:12:19 UTC) #6
r
ok leaving for adg
13 years ago (2012-03-06 23:10:27 UTC) #7
adg
LGTM
13 years ago (2012-03-07 00:23:37 UTC) #8
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=9353aa1efdf3 *** doc: fix typos in laws_of_reflection article, add copyright notice. Update ...
13 years ago (2012-03-07 00:24:07 UTC) #9
proppy
*** Abandoned ***
13 years ago (2012-03-13 15:46:43 UTC) #10
proppy
13 years ago (2012-03-13 15:47:04 UTC) #11
On 2012/03/13 15:46:43, proppy wrote:
> *** Abandoned ***

Not Abandoned (again).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b