Issue 5742043: code review 5742043: cmd/gc: if $GOROOT_FINAL is set, rewrite file names in ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5742043: code review 5742043: cmd/gc: if $GOROOT_FINAL is set, rewrite file names in ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by rsc

Modified:
13 years ago

Reviewers:

CC:
ken2, ken3, golang-dev

Visibility:
Public.

Description

cmd/gc: if $GOROOT_FINAL is set, rewrite file names in object files GOROOT_FINAL is a build parameter that means "eventually the Go tree will be installed here". Make the file name information match that eventual location. Fixes issue 3180.

Patch Set 1 #

Patch Set 2 : diff -r 4e1e3f3a7e11 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7edc1081439f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 483444f87009 https://go.googlecode.com/hg/ #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
M	src/cmd/dist/build.c	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/gc/obj.c	View	1	2 chunks	+31 lines, -1 line	0 comments	Download
M	test/run	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years ago (2012-03-05 20:17:17 UTC) #1

rsc

13 years ago (2012-03-05 21:13:38 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ba91b34fe212 ***

cmd/gc: if $GOROOT_FINAL is set, rewrite file names in object files

GOROOT_FINAL is a build parameter that means "eventually
the Go tree will be installed here".  Make the file name information
match that eventual location.

Fixes issue 3180.

R=ken, ken
CC=golang-dev
http://codereview.appspot.com/5742043

Expand All Messages | Collapse All Messages