code review 5738044: go.image/tiff: simplify encoding.

go.image/tiff: simplify encoding.

[nigeltao, 2012-03-05 01:07:13]

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.image

[nigeltao, 2012-03-05 01:07:32]

What do you think?

[bsiegert, 2012-03-05 13:21:13]

Thanks a lot for doing this. The code is much simpler and cleaner.

http://codereview.appspot.com/5738044/diff/5001/tiff/writer.go
File tiff/writer.go (right):

http://codereview.appspot.com/5738044/diff/5001/tiff/writer.go#newcode57
tiff/writer.go:57: b := m.Bounds()
Now that I think about it, this variable should maybe be named bounds, b is used
as part of r,g,b,a below. What do you think?

http://codereview.appspot.com/5738044/diff/5001/tiff/writer.go#newcode142
tiff/writer.go:142: ifdOffset := imageLen + 8 // 8 bytes for TIFF header.
Move the definition of imageLen before this line.

[nigeltao, 2012-03-05 23:35:04]

http://codereview.appspot.com/5738044/diff/5001/tiff/writer.go
File tiff/writer.go (right):

http://codereview.appspot.com/5738044/diff/5001/tiff/writer.go#newcode57
tiff/writer.go:57: b := m.Bounds()
On 2012/03/05 13:21:14, bsiegert wrote:
> Now that I think about it, this variable should maybe be named bounds, b is
used
> as part of r,g,b,a below. What do you think?

Done.

http://codereview.appspot.com/5738044/diff/5001/tiff/writer.go#newcode142
tiff/writer.go:142: ifdOffset := imageLen + 8 // 8 bytes for TIFF header.
On 2012/03/05 13:21:14, bsiegert wrote:
> Move the definition of imageLen before this line.

Done.

[bsiegert, 2012-03-06 11:30:43]

LGTM

[nigeltao, 2012-03-06 23:32:53]

*** Submitted as
http://code.google.com/p/go/source/detail?r=f4f5c13d8968&repo=image ***

go.image/tiff: simplify encoding.

R=bsiegert
CC=golang-dev
http://codereview.appspot.com/5738044